From: Tom Tromey <tromey@redhat.com>
To: hex <heixia108@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH]Add symbol whose field 'has_type' has been set to partial symbol table
Date: Tue, 29 Oct 2013 18:34:00 -0000 [thread overview]
Message-ID: <871u347wpy.fsf@fleche.redhat.com> (raw)
In-Reply-To: <CAB_AMN7ZyhaNKZsn3WLZmRyHe4SBxMsMbuXEdmMkvGhiXdnwcw@mail.gmail.com> (hex's message of "Fri, 25 Oct 2013 15:41:28 +0800")
>>>>> ">" == hex <heixia108@gmail.com> writes:
>> Thank you for the review. I have attached the test case.
The test case needs a ChangeLog entry.
I'd much prefer a test using the DWARF assembler than one using actual
assembly code. There are other examples in gdb.dwarf2. The reason to
prefer the DWARF assembler is that it is more portable.
>> # You should have received a copy of the GNU General Public License
>> # along with this program. If not, see <http://www.gnu.org/licenses/>.
>> load_lib dwarf.exp
A blank line between the comments and the first line of code, please.
>> # Test DW_OP_stack_value and DW_OP_implicit_value.
This comment seems incorrect.
Tom
next prev parent reply other threads:[~2013-10-29 18:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 6:59 hex
2013-10-24 20:31 ` Tom Tromey
2013-10-25 7:41 ` hex
2013-10-29 18:34 ` Tom Tromey [this message]
2013-11-01 6:29 hex
2013-11-07 15:41 ` Tom Tromey
2014-01-24 6:19 Jun Gong
2014-01-26 9:15 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871u347wpy.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=heixia108@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox