From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14403 invoked by alias); 29 Oct 2013 18:34:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14394 invoked by uid 89); 29 Oct 2013 18:34:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 29 Oct 2013 18:34:06 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9TIY3uR023319 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 29 Oct 2013 14:34:03 -0400 Received: from barimba (ovpn-113-94.phx2.redhat.com [10.3.113.94]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r9TIY2mU032486 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 29 Oct 2013 14:34:02 -0400 From: Tom Tromey To: hex Cc: gdb-patches@sourceware.org Subject: Re: [PATCH]Add symbol whose field 'has_type' has been set to partial symbol table References: <874n869zs9.fsf@fleche.redhat.com> Date: Tue, 29 Oct 2013 18:34:00 -0000 In-Reply-To: (hex's message of "Fri, 25 Oct 2013 15:41:28 +0800") Message-ID: <871u347wpy.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-10/txt/msg00912.txt.bz2 >>>>> ">" == hex writes: >> Thank you for the review. I have attached the test case. The test case needs a ChangeLog entry. I'd much prefer a test using the DWARF assembler than one using actual assembly code. There are other examples in gdb.dwarf2. The reason to prefer the DWARF assembler is that it is more portable. >> # You should have received a copy of the GNU General Public License >> # along with this program. If not, see . >> load_lib dwarf.exp A blank line between the comments and the first line of code, please. >> # Test DW_OP_stack_value and DW_OP_implicit_value. This comment seems incorrect. Tom