From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6166 invoked by alias); 1 Nov 2013 06:29:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6154 invoked by uid 89); 1 Nov 2013 06:29:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oa0-f48.google.com Received: from mail-oa0-f48.google.com (HELO mail-oa0-f48.google.com) (209.85.219.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 01 Nov 2013 06:29:38 +0000 Received: by mail-oa0-f48.google.com with SMTP id m17so4107831oag.7 for ; Thu, 31 Oct 2013 23:29:36 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.60.155.166 with SMTP id vx6mr1326951oeb.28.1383287376771; Thu, 31 Oct 2013 23:29:36 -0700 (PDT) Received: by 10.60.45.207 with HTTP; Thu, 31 Oct 2013 23:29:36 -0700 (PDT) Date: Fri, 01 Nov 2013 06:29:00 -0000 Message-ID: Subject: Re: [PATCH]Add symbol whose field 'has_type' has been set to partial symbol table From: hex To: Tom Tromey Cc: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=047d7bf18754b7117a04ea17b0fc X-SW-Source: 2013-11/txt/msg00003.txt.bz2 --047d7bf18754b7117a04ea17b0fc Content-Type: text/plain; charset=ISO-8859-1 Content-length: 1040 > 2013/10/30 Tom Tromey > > >>>>> ">" == hex writes: > > >> Thank you for the review. I have attached the test case. > > The test case needs a ChangeLog entry. > > I'd much prefer a test using the DWARF assembler than one using actual > assembly code. There are other examples in gdb.dwarf2. The reason to > prefer the DWARF assembler is that it is more portable. > > >> # You should have received a copy of the GNU General Public License > >> # along with this program. If not, see . > >> load_lib dwarf.exp > > A blank line between the comments and the first line of code, please. > > >> # Test DW_OP_stack_value and DW_OP_implicit_value. > > This comment seems incorrect. > > Tom Thank you for the comments. A new version of test file is attached. And the original patch is at https://sourceware.org/ml/gdb-patches/2013-10/msg00747.html. gdb/testsuite/Changelog: 2013-11-01 Jun Gong * gdb.dwarf2/const-var.exp: New file. Jun --047d7bf18754b7117a04ea17b0fc Content-Type: application/octet-stream; name="const-var.exp" Content-Disposition: attachment; filename="const-var.exp" Content-Transfer-Encoding: base64 X-Attachment-Id: ca74f45d988a26f1_0.1 Content-length: 2371 IyBDb3B5cmlnaHQgMjAxMyBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIElu Yy4KCiMgVGhpcyBwcm9ncmFtIGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4g cmVkaXN0cmlidXRlIGl0IGFuZC9vciBtb2RpZnkKIyBpdCB1bmRlciB0aGUg dGVybXMgb2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGFzIHB1 Ymxpc2hlZCBieQojIHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb247IGVp dGhlciB2ZXJzaW9uIDMgb2YgdGhlIExpY2Vuc2UsIG9yCiMgKGF0IHlvdXIg b3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lvbi4KIwojIFRoaXMgcHJvZ3JhbSBp cyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUgdXNl ZnVsLAojIGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBldmVu IHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mCiMgTUVSQ0hBTlRBQklMSVRZIG9y IEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZQoj IEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMu CiMKIyBZb3Ugc2hvdWxkIGhhdmUgcmVjZWl2ZWQgYSBjb3B5IG9mIHRoZSBH TlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZQojIGFsb25nIHdpdGggdGhpcyBw cm9ncmFtLiAgSWYgbm90LCBzZWUgPGh0dHA6Ly93d3cuZ251Lm9yZy9saWNl bnNlcy8+LgoKbG9hZF9saWIgZHdhcmYuZXhwCgojIFRoaXMgdGVzdCBjYW4g b25seSBiZSBydW4gb24gdGFyZ2V0cyB3aGljaCBzdXBwb3J0IERXQVJGLTIg YW5kIHVzZSBnYXMuCmlmIHshW2R3YXJmMl9zdXBwb3J0XX0gewogICAgcmV0 dXJuIDAKfQoKc3RhbmRhcmRfdGVzdGZpbGUgbWFpbi5jIC5TCgojIENyZWF0 ZSB0aGUgRFdBUkYuCnNldCBhc21fZmlsZSBbc3RhbmRhcmRfb3V0cHV0X2Zp bGUgJHNyY2ZpbGUyXQpEd2FyZjo6YXNzZW1ibGUgJGFzbV9maWxlIHsKICAg IGRlY2xhcmVfbGFiZWxzIGludF9sYWJlbAoKICAgIGN1IHt9IHsKCWNvbXBp bGVfdW5pdCB7e2xhbmd1YWdlIEBEV19MQU5HX0N9fSB7CgkgICAgaW50X2xh YmVsOiBiYXNlX3R5cGUgewoJCXtuYW1lIGludH0KCQl7Ynl0ZV9zaXplIDQg c2RhdGF9CgkJe2VuY29kaW5nIEBEV19BVEVfc2lnbmVkfQoJICAgIH0KCgkg ICAgRFdfVEFHX3ZhcmlhYmxlIHsKCQl7bmFtZSBjb25zdF92YXJ9CgkJe3R5 cGUgOiRpbnRfbGFiZWx9CgkJe2NvbnN0X3ZhbHVlIDYgZGF0YTF9CgkgICAg fQoJfQogICAgfQp9CgppZiAgeyBbZ2RiX2NvbXBpbGUgJHtzcmNkaXJ9LyR7 c3ViZGlyfS8ke3NyY2ZpbGV9ICR7YmluZmlsZX0xLm8gXAoJICAgb2JqZWN0 IHtub2RlYnVnfV0gIT0gIiIgfSB7CiAgICByZXR1cm4gLTEKfQoKaWYgIHsg W2dkYl9jb21waWxlICRhc21fZmlsZSAke2JpbmZpbGV9Mi5vIG9iamVjdCB7 bm9kZWJ1Z31dICE9ICIiIH0gewogICAgcmV0dXJuIC0xCn0KCmlmICB7IFtn ZGJfY29tcGlsZSBbbGlzdCAke2JpbmZpbGV9MS5vICR7YmluZmlsZX0yLm9d IFwKCSAgICIke2JpbmZpbGV9IiBleGVjdXRhYmxlIHt9XSAhPSAiIiB9IHsK ICAgIHJldHVybiAtMQp9CgpjbGVhbl9yZXN0YXJ0ICR7dGVzdGZpbGV9Cgpp ZiAhW3J1bnRvX21haW5dIHsKICAgIHJldHVybiAtMQp9CgojIFByaW50IGNv bnN0IHZhcmlhYmxlLCB0ZXN0IHdoZXRoZXIgaXQgaGFzIGJlZW4gYWRkZWQg dG8gcGFydGlhbAojIHN5bWJvbCB0YWJsZS4KZ2RiX3Rlc3QgInByaW50IGNv bnN0X3ZhciIgIiA9IDYiICJwcmludCBjb25zdCB2YXJpYWJsZSIK --047d7bf18754b7117a04ea17b0fc--