From: Sergio Lopez <slp@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/4] Implement 'set honor-dontdump-flag' command
Date: Tue, 28 Nov 2017 15:06:00 -0000 [thread overview]
Message-ID: <CAAiTLFUYJsgrm+bVkfTmhngDxciAmgm9M5WUFqUySptfzZ1gVQ@mail.gmail.com> (raw)
In-Reply-To: <20171128132148.31802-2-slp@redhat.com>
On Tue, Nov 28, 2017 at 2:21 PM, Sergio Lopez <slp@redhat.com> wrote:
> + add_setshow_boolean_cmd ("honor-dontdump-flag", class_files,
> + &honor_dontdump_flag, _("\
> +Set whether gcore should honor the VM_DONTDUMP flag."),
> + _("\
> +Show whether gcore should honor the VM_DONTDUMP flag."),
> + _("\
> +Use this command to set whether gcore should honor the VM_DONTDUMP\n\
> +flag from /proc/PID/smaps when generating the corefile. For more information\n\
> +about this file, refer to the manpage of proc(5) and core(5)."),
> + NULL, show_use_coredump_filter,
> + &setlist, &showlist);
> }
A colleague spotted that I forgot to implement and use a different
"show" function for honor-dontdump-flag, wrongly reusing
show_use_coredump_filter.
I'm going to wait for feedback on the rest of the patchset. Will post
a v2 afterward.
--
Sergio
next prev parent reply other threads:[~2017-11-28 15:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 13:22 [PATCH 0/4] Enable the user to dump all memory regions Sergio Lopez
2017-11-28 13:22 ` [PATCH 3/4] Add "-a" argument to gcore.in Sergio Lopez
2017-11-28 15:57 ` Sergio Durigan Junior
2017-11-28 13:22 ` [PATCH 2/4] Document new 'set honor-dontdump-flag' command Sergio Lopez
2017-11-28 15:51 ` Sergio Durigan Junior
2017-11-28 16:32 ` Pedro Alves
2017-11-28 16:39 ` Eli Zaretskii
2017-11-28 13:22 ` [PATCH 1/4] Implement " Sergio Lopez
2017-11-28 15:06 ` Sergio Lopez [this message]
2017-11-28 15:42 ` Sergio Durigan Junior
2017-11-28 16:21 ` Pedro Alves
2017-11-28 16:36 ` Sergio Durigan Junior
2017-11-29 10:59 ` Sergio Lopez
2017-11-29 19:39 ` Sergio Durigan Junior
2017-11-29 20:02 ` Sergio Lopez
2017-11-29 20:22 ` Sergio Durigan Junior
2017-11-28 13:22 ` [PATCH 4/4] Document the new "-a" argument for gcore Sergio Lopez
2017-11-28 15:54 ` Sergio Durigan Junior
2017-11-28 16:35 ` Eli Zaretskii
2017-11-28 18:37 ` John Baldwin
2017-11-28 16:08 ` [PATCH 0/4] Enable the user to dump all memory regions Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAiTLFUYJsgrm+bVkfTmhngDxciAmgm9M5WUFqUySptfzZ1gVQ@mail.gmail.com \
--to=slp@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox