From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 115588 invoked by alias); 28 Nov 2017 15:06:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 115574 invoked by uid 89); 28 Nov 2017 15:06:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.2 spammy=colleague, Hx-languages-length:903 X-HELO: mail-io0-f181.google.com Received: from mail-io0-f181.google.com (HELO mail-io0-f181.google.com) (209.85.223.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 28 Nov 2017 15:06:07 +0000 Received: by mail-io0-f181.google.com with SMTP id u42so105588ioi.9 for ; Tue, 28 Nov 2017 07:06:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=7PfqsrqSfFkq4cdXGHuS6aM0arKcr94P31kvYK/qmkw=; b=I4Xy7ij58PLt1tOIigMYE7H6os0QDQRejvrFTUqKbdp5tffdWQTRGbhIjA+og+SekQ J0vo2i6csnnrzBCNH3/QwWghPAlhoJgo8E25Obf6U34w20tEIzgxdsBOwI/Dt3Scydu5 aZzSXLUxiblPgdlKqeGVZqLfcRKpCxH4nHsvmvpuEeAOv5Bb4yScXwO+aQfGlsvvkL99 L9p10Azu3UwbnAC6uj12RmFkemsUBWxtOCSBFb2aK3ZAGgwvfhLJ3vjKZhwrt533YsRt MuBvmG6mipbPYM6OwhPhkxg/20z+K5CfxDghZ4urimFq1fPvWCA0wNkvooYHgIvBe6mk 4CAQ== X-Gm-Message-State: AJaThX4jw/Wc2X5l/6A8RxCkqK3JzgbZ/yejJ1IMAafF/FKq+Bdcdj0E E7VZ1icG0vnT0O8M81CXa9Ono3gbKeY+Ai+rmndFmCqk X-Google-Smtp-Source: AGs4zMZatUVvC6szV7ADpUhcIUNrkvO34trkIx6NuWFQUKYgmhvcshZWf+0BwkgyTG18O0QttOIh/i6TuyiORzV3a5U= X-Received: by 10.107.175.165 with SMTP id p37mr48694725ioo.32.1511881565546; Tue, 28 Nov 2017 07:06:05 -0800 (PST) MIME-Version: 1.0 Received: by 10.2.72.71 with HTTP; Tue, 28 Nov 2017 07:06:04 -0800 (PST) In-Reply-To: <20171128132148.31802-2-slp@redhat.com> References: <20171128132148.31802-1-slp@redhat.com> <20171128132148.31802-2-slp@redhat.com> From: Sergio Lopez Date: Tue, 28 Nov 2017 15:06:00 -0000 Message-ID: Subject: Re: [PATCH 1/4] Implement 'set honor-dontdump-flag' command To: gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" X-SW-Source: 2017-11/txt/msg00729.txt.bz2 On Tue, Nov 28, 2017 at 2:21 PM, Sergio Lopez wrote: > + add_setshow_boolean_cmd ("honor-dontdump-flag", class_files, > + &honor_dontdump_flag, _("\ > +Set whether gcore should honor the VM_DONTDUMP flag."), > + _("\ > +Show whether gcore should honor the VM_DONTDUMP flag."), > + _("\ > +Use this command to set whether gcore should honor the VM_DONTDUMP\n\ > +flag from /proc/PID/smaps when generating the corefile. For more information\n\ > +about this file, refer to the manpage of proc(5) and core(5)."), > + NULL, show_use_coredump_filter, > + &setlist, &showlist); > } A colleague spotted that I forgot to implement and use a different "show" function for honor-dontdump-flag, wrongly reusing show_use_coredump_filter. I'm going to wait for feedback on the rest of the patchset. Will post a v2 afterward. -- Sergio