From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Sergio Lopez <slp@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/4] Implement 'set honor-dontdump-flag' command
Date: Wed, 29 Nov 2017 20:22:00 -0000 [thread overview]
Message-ID: <874lpchm2r.fsf@redhat.com> (raw)
In-Reply-To: <CAAiTLFU9eoh849fECgAn=HubScTrQQPP_18iRioDO1EY6rdW-w@mail.gmail.com> (Sergio Lopez's message of "Wed, 29 Nov 2017 21:02:36 +0100")
On Wednesday, November 29 2017, Sergio Lopez wrote:
> On Wed, Nov 29, 2017 at 8:39 PM, Sergio Durigan Junior
> <sergiodj@redhat.com> wrote:
>> The previous line is the one breaking our coding style. Unfortunately
>> GDB is full of these inconsistencies, but please remove the empty line
>> in your patch anyway.
>
> Ack, not a problem.
>
> Is there something else you'd like to see fixed in v3? In case you
> don't, do you prefer me to send the whole patchset as v3, or just
> patch 1/4?
The only thing I'd like is a testcase for this feature. This is
required since it is a regression. If you need any help to write one,
please let me know.
Once you have a testcase, you could just send patch 1/4 again.
Thanks,
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
next prev parent reply other threads:[~2017-11-29 20:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 13:22 [PATCH 0/4] Enable the user to dump all memory regions Sergio Lopez
2017-11-28 13:22 ` [PATCH 1/4] Implement 'set honor-dontdump-flag' command Sergio Lopez
2017-11-28 15:06 ` Sergio Lopez
2017-11-28 15:42 ` Sergio Durigan Junior
2017-11-28 16:21 ` Pedro Alves
2017-11-28 16:36 ` Sergio Durigan Junior
2017-11-29 10:59 ` Sergio Lopez
2017-11-29 19:39 ` Sergio Durigan Junior
2017-11-29 20:02 ` Sergio Lopez
2017-11-29 20:22 ` Sergio Durigan Junior [this message]
2017-11-28 13:22 ` [PATCH 2/4] Document new " Sergio Lopez
2017-11-28 15:51 ` Sergio Durigan Junior
2017-11-28 16:32 ` Pedro Alves
2017-11-28 16:39 ` Eli Zaretskii
2017-11-28 13:22 ` [PATCH 3/4] Add "-a" argument to gcore.in Sergio Lopez
2017-11-28 15:57 ` Sergio Durigan Junior
2017-11-28 13:22 ` [PATCH 4/4] Document the new "-a" argument for gcore Sergio Lopez
2017-11-28 15:54 ` Sergio Durigan Junior
2017-11-28 16:35 ` Eli Zaretskii
2017-11-28 18:37 ` John Baldwin
2017-11-28 16:08 ` [PATCH 0/4] Enable the user to dump all memory regions Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874lpchm2r.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=slp@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox