From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82751 invoked by alias); 29 Nov 2017 20:22:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 82741 invoked by uid 89); 29 Nov 2017 20:22:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.7 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,KB_WAM_FROM_NAME_SINGLEWORD,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=our X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 Nov 2017 20:22:23 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A38C35D686 for ; Wed, 29 Nov 2017 20:22:22 +0000 (UTC) Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7853460605; Wed, 29 Nov 2017 20:22:20 +0000 (UTC) From: Sergio Durigan Junior To: Sergio Lopez Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/4] Implement 'set honor-dontdump-flag' command References: <20171128132148.31802-1-slp@redhat.com> <20171128132148.31802-2-slp@redhat.com> <87induo1ey.fsf@redhat.com> <87a7z4ho1q.fsf@redhat.com> Date: Wed, 29 Nov 2017 20:22:00 -0000 In-Reply-To: (Sergio Lopez's message of "Wed, 29 Nov 2017 21:02:36 +0100") Message-ID: <874lpchm2r.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00795.txt.bz2 On Wednesday, November 29 2017, Sergio Lopez wrote: > On Wed, Nov 29, 2017 at 8:39 PM, Sergio Durigan Junior > wrote: >> The previous line is the one breaking our coding style. Unfortunately >> GDB is full of these inconsistencies, but please remove the empty line >> in your patch anyway. > > Ack, not a problem. > > Is there something else you'd like to see fixed in v3? In case you > don't, do you prefer me to send the whole patchset as v3, or just > patch 1/4? The only thing I'd like is a testcase for this feature. This is required since it is a regression. If you need any help to write one, please let me know. Once you have a testcase, you could just send patch 1/4 again. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/