* [PATCH] [PR gdb/19495] Removed redundant line remote-utils.c
@ 2016-09-02 15:40 Akash Trehan
2016-09-02 16:52 ` Manish Goregaokar
0 siblings, 1 reply; 3+ messages in thread
From: Akash Trehan @ 2016-09-02 15:40 UTC (permalink / raw)
To: gdb-patches
The tests successfully ran after the patch.
Also I've requested for copyright assignment. I'm not sure if I really
need it for this patch, do I?
2016-09-02 Akash Trehan <akash.trehan123@gmail.com>
gdb/gdbserver/ChangeLog:
PR gdb/19495
* remote-utils.c (relocate_instruction): Remove redundant strcpy()
call writing data to own_buf.
---
gdb/gdbserver/remote-utils.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/gdb/gdbserver/remote-utils.c b/gdb/gdbserver/remote-utils.c
index 768d2e9..1d51010 100644
--- a/gdb/gdbserver/remote-utils.c
+++ b/gdb/gdbserver/remote-utils.c
@@ -1579,7 +1579,6 @@ relocate_instruction (CORE_ADDR *to, CORE_ADDR oldloc)
ULONGEST written = 0;
/* Send the request. */
- strcpy (own_buf, "qRelocInsn:");
sprintf (own_buf, "qRelocInsn:%s;%s", paddress (oldloc),
paddress (*to));
if (putpkt (own_buf) < 0)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [PR gdb/19495] Removed redundant line remote-utils.c
2016-09-02 15:40 [PATCH] [PR gdb/19495] Removed redundant line remote-utils.c Akash Trehan
@ 2016-09-02 16:52 ` Manish Goregaokar
2016-09-03 10:41 ` Pedro Alves
0 siblings, 1 reply; 3+ messages in thread
From: Manish Goregaokar @ 2016-09-02 16:52 UTC (permalink / raw)
To: Akash Trehan; +Cc: gdb-patches
Reformatted patch below. Please ensure that the diff is one which
can be imported via `git apply`
2016-09-02 Akash Trehan <akash.trehan123@gmail.com>
gdb/gdbserver/ChangeLog:
PR gdb/19495
* remote-utils.c (relocate_instruction): Remove redundant strcpy()
call writing data to own_buf.
---
gdb/gdbserver/remote-utils.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/gdb/gdbserver/remote-utils.c b/gdb/gdbserver/remote-utils.c
index 768d2e9..1d51010 100644
--- a/gdb/gdbserver/remote-utils.c
+++ b/gdb/gdbserver/remote-utils.c
@@ -1579,7 +1579,6 @@ relocate_instruction (CORE_ADDR *to, CORE_ADDR oldloc)
ULONGEST written = 0;
/* Send the request. */
- strcpy (own_buf, "qRelocInsn:");
sprintf (own_buf, "qRelocInsn:%s;%s", paddress (oldloc),
paddress (*to));
if (putpkt (own_buf) < 0)
--
2.8.3
Thanks,
-Manish
-Manish
On Fri, Sep 2, 2016 at 9:10 PM, Akash Trehan <akash.trehan123@gmail.com> wrote:
> The tests successfully ran after the patch.
> Also I've requested for copyright assignment. I'm not sure if I really
> need it for this patch, do I?
>
>
> 2016-09-02 Akash Trehan <akash.trehan123@gmail.com>
>
>
> gdb/gdbserver/ChangeLog:
>
> PR gdb/19495
>
> * remote-utils.c (relocate_instruction): Remove redundant strcpy()
>
> call writing data to own_buf.
>
> ---
>
> gdb/gdbserver/remote-utils.c | 1 -
>
> 1 file changed, 1 deletion(-)
>
>
>
>
> diff --git a/gdb/gdbserver/remote-utils.c b/gdb/gdbserver/remote-utils.c
>
> index 768d2e9..1d51010 100644
>
> --- a/gdb/gdbserver/remote-utils.c
>
> +++ b/gdb/gdbserver/remote-utils.c
>
> @@ -1579,7 +1579,6 @@ relocate_instruction (CORE_ADDR *to, CORE_ADDR oldloc)
>
> ULONGEST written = 0;
>
>
>
> /* Send the request. */
>
> - strcpy (own_buf, "qRelocInsn:");
>
> sprintf (own_buf, "qRelocInsn:%s;%s", paddress (oldloc),
>
> paddress (*to));
>
> if (putpkt (own_buf) < 0)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [PR gdb/19495] Removed redundant line remote-utils.c
2016-09-02 16:52 ` Manish Goregaokar
@ 2016-09-03 10:41 ` Pedro Alves
0 siblings, 0 replies; 3+ messages in thread
From: Pedro Alves @ 2016-09-03 10:41 UTC (permalink / raw)
To: Manish Goregaokar, Akash Trehan; +Cc: gdb-patches
OK, please push.
Thanks,
Pedro Alves
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-03 10:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-02 15:40 [PATCH] [PR gdb/19495] Removed redundant line remote-utils.c Akash Trehan
2016-09-02 16:52 ` Manish Goregaokar
2016-09-03 10:41 ` Pedro Alves
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox