From: Manish Goregaokar <manish@mozilla.com>
To: Akash Trehan <akash.trehan123@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] [PR gdb/19495] Removed redundant line remote-utils.c
Date: Fri, 02 Sep 2016 16:52:00 -0000 [thread overview]
Message-ID: <CAFOnWk=hB2xRNJmT=n4vOCKKHQasPGDyiYhERTkqmXwb6gGFMQ@mail.gmail.com> (raw)
In-Reply-To: <CA+MaScmksSaZVtpeHP6McrPG_yiJWKJe_EXyHSON_FPpsCh5uA@mail.gmail.com>
Reformatted patch below. Please ensure that the diff is one which
can be imported via `git apply`
2016-09-02 Akash Trehan <akash.trehan123@gmail.com>
gdb/gdbserver/ChangeLog:
PR gdb/19495
* remote-utils.c (relocate_instruction): Remove redundant strcpy()
call writing data to own_buf.
---
gdb/gdbserver/remote-utils.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/gdb/gdbserver/remote-utils.c b/gdb/gdbserver/remote-utils.c
index 768d2e9..1d51010 100644
--- a/gdb/gdbserver/remote-utils.c
+++ b/gdb/gdbserver/remote-utils.c
@@ -1579,7 +1579,6 @@ relocate_instruction (CORE_ADDR *to, CORE_ADDR oldloc)
ULONGEST written = 0;
/* Send the request. */
- strcpy (own_buf, "qRelocInsn:");
sprintf (own_buf, "qRelocInsn:%s;%s", paddress (oldloc),
paddress (*to));
if (putpkt (own_buf) < 0)
--
2.8.3
Thanks,
-Manish
-Manish
On Fri, Sep 2, 2016 at 9:10 PM, Akash Trehan <akash.trehan123@gmail.com> wrote:
> The tests successfully ran after the patch.
> Also I've requested for copyright assignment. I'm not sure if I really
> need it for this patch, do I?
>
>
> 2016-09-02 Akash Trehan <akash.trehan123@gmail.com>
>
>
> gdb/gdbserver/ChangeLog:
>
> PR gdb/19495
>
> * remote-utils.c (relocate_instruction): Remove redundant strcpy()
>
> call writing data to own_buf.
>
> ---
>
> gdb/gdbserver/remote-utils.c | 1 -
>
> 1 file changed, 1 deletion(-)
>
>
>
>
> diff --git a/gdb/gdbserver/remote-utils.c b/gdb/gdbserver/remote-utils.c
>
> index 768d2e9..1d51010 100644
>
> --- a/gdb/gdbserver/remote-utils.c
>
> +++ b/gdb/gdbserver/remote-utils.c
>
> @@ -1579,7 +1579,6 @@ relocate_instruction (CORE_ADDR *to, CORE_ADDR oldloc)
>
> ULONGEST written = 0;
>
>
>
> /* Send the request. */
>
> - strcpy (own_buf, "qRelocInsn:");
>
> sprintf (own_buf, "qRelocInsn:%s;%s", paddress (oldloc),
>
> paddress (*to));
>
> if (putpkt (own_buf) < 0)
next prev parent reply other threads:[~2016-09-02 16:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 15:40 Akash Trehan
2016-09-02 16:52 ` Manish Goregaokar [this message]
2016-09-03 10:41 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFOnWk=hB2xRNJmT=n4vOCKKHQasPGDyiYhERTkqmXwb6gGFMQ@mail.gmail.com' \
--to=manish@mozilla.com \
--cc=akash.trehan123@gmail.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox