From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83187 invoked by alias); 2 Sep 2016 16:52:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 83176 invoked by uid 89); 2 Sep 2016 16:51:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-wm0-f53.google.com Received: from mail-wm0-f53.google.com (HELO mail-wm0-f53.google.com) (74.125.82.53) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 02 Sep 2016 16:51:57 +0000 Received: by mail-wm0-f53.google.com with SMTP id 1so40993829wmz.1 for ; Fri, 02 Sep 2016 09:51:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=xRtqUTq9cCnWniEMehZ6N+lddssRcyY4rvBLX26IOac=; b=QoPQlaWCudbspKZ1IGqUbKpWusa9B02n/a7naI4duQnf6ob16Rcufl0bHsTvfXKEGm 6jU47ADQxAPQkH1JI6tVqZbwGt5m/J4DgOFvheSPo7yC7fBnk1zFgXBtdVNuNsFf7GZN ofo1ZYNv/v52kt1fLu/2WvzulO2bjV1u7DBR/QVmAx5AkgB4pGGAbhukKs8qsPYdV9eI W/1CDj7nUwz4/efh1sM5Cou9J4fyLur457y+x8vLvcv3gKjHP4LcICH2F9nj//Ivxucf FA0Sofq7kM+K56zTSt78hW9YGbGfH3ikzrVYHIla9FnPTm7Me7wg2n0ntEqkTc5Utgc+ AcHA== X-Gm-Message-State: AE9vXwN34v2JZJrv1YIOFNfsEBd5YC0oBA16Zz9CsP3tByfVknrisrE2v+2BC/KhPGBeE8YpUDp42NgFhBewgnkF X-Received: by 10.194.37.101 with SMTP id x5mr22841135wjj.95.1472835115795; Fri, 02 Sep 2016 09:51:55 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.131.12 with HTTP; Fri, 2 Sep 2016 09:51:35 -0700 (PDT) In-Reply-To: References: From: Manish Goregaokar Date: Fri, 02 Sep 2016 16:52:00 -0000 Message-ID: Subject: Re: [PATCH] [PR gdb/19495] Removed redundant line remote-utils.c To: Akash Trehan Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2016-09/txt/msg00045.txt.bz2 Reformatted patch below. Please ensure that the diff is one which can be imported via `git apply` 2016-09-02 Akash Trehan gdb/gdbserver/ChangeLog: PR gdb/19495 * remote-utils.c (relocate_instruction): Remove redundant strcpy() call writing data to own_buf. --- gdb/gdbserver/remote-utils.c | 1 - 1 file changed, 1 deletion(-) diff --git a/gdb/gdbserver/remote-utils.c b/gdb/gdbserver/remote-utils.c index 768d2e9..1d51010 100644 --- a/gdb/gdbserver/remote-utils.c +++ b/gdb/gdbserver/remote-utils.c @@ -1579,7 +1579,6 @@ relocate_instruction (CORE_ADDR *to, CORE_ADDR oldloc) ULONGEST written = 0; /* Send the request. */ - strcpy (own_buf, "qRelocInsn:"); sprintf (own_buf, "qRelocInsn:%s;%s", paddress (oldloc), paddress (*to)); if (putpkt (own_buf) < 0) -- 2.8.3 Thanks, -Manish -Manish On Fri, Sep 2, 2016 at 9:10 PM, Akash Trehan wrote: > The tests successfully ran after the patch. > Also I've requested for copyright assignment. I'm not sure if I really > need it for this patch, do I? > > > 2016-09-02 Akash Trehan > > > gdb/gdbserver/ChangeLog: > > PR gdb/19495 > > * remote-utils.c (relocate_instruction): Remove redundant strcpy() > > call writing data to own_buf. > > --- > > gdb/gdbserver/remote-utils.c | 1 - > > 1 file changed, 1 deletion(-) > > > > > diff --git a/gdb/gdbserver/remote-utils.c b/gdb/gdbserver/remote-utils.c > > index 768d2e9..1d51010 100644 > > --- a/gdb/gdbserver/remote-utils.c > > +++ b/gdb/gdbserver/remote-utils.c > > @@ -1579,7 +1579,6 @@ relocate_instruction (CORE_ADDR *to, CORE_ADDR oldloc) > > ULONGEST written = 0; > > > > /* Send the request. */ > > - strcpy (own_buf, "qRelocInsn:"); > > sprintf (own_buf, "qRelocInsn:%s;%s", paddress (oldloc), > > paddress (*to)); > > if (putpkt (own_buf) < 0)