From: Tristan Gingold <gingold@adacore.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA Darwin]: Add push_dummy_call for i386
Date: Tue, 07 Jul 2009 08:15:00 -0000 [thread overview]
Message-ID: <C4869BB5-4314-47DD-AA04-7806DD37CE7A@adacore.com> (raw)
In-Reply-To: <200907061016.n66AGPFQ000907@brahms.sibelius.xs4all.nl>
On Jul 6, 2009, at 12:16 PM, Mark Kettenis wrote:
>> I quoted LowLevelABI.pdf. What is wrong in this sentence ? (Keep
>> in mind that I am not a native english speaker!)
>
> Heh well, if it is a quotation, better not change it. But perhaps the
> comment should indicate this is a quotation from the ABI document?
I propose this:
/* According to Mac OS X ABI document (passing arguments):
6. The caller places 64-bit vectors (__m64) on the parameter
area,
aligned to 8-byte boundaries.
7. [...] The caller aligns 128-bit vectors in the parameter
area to
16-byte boundaries. */
Is it OK with that change (or do you prefer to review the whole patch
again) ?
Tristan.
next prev parent reply other threads:[~2009-07-07 8:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-03 15:52 Tristan Gingold
2009-07-03 16:49 ` Mark Kettenis
2009-07-06 7:08 ` Tristan Gingold
2009-07-06 10:16 ` Mark Kettenis
2009-07-07 8:15 ` Tristan Gingold [this message]
2009-07-03 16:55 ` Joseph S. Myers
2009-07-06 7:00 ` Tristan Gingold
2009-07-04 15:31 ` H.J. Lu
2009-07-06 6:56 ` Tristan Gingold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C4869BB5-4314-47DD-AA04-7806DD37CE7A@adacore.com \
--to=gingold@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox