From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-65198-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 14181 invoked by alias); 7 Jul 2009 08:15:51 -0000
Received: (qmail 14030 invoked by uid 22791); 7 Jul 2009 08:15:50 -0000
X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (212.99.106.210)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 07 Jul 2009 08:15:44 +0000
Received: from localhost (localhost [127.0.0.1]) 	by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id C8576290030; 	Tue,  7 Jul 2009 10:15:41 +0200 (CEST)
Received: from mel.act-europe.fr ([127.0.0.1]) 	by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) 	with ESMTP id wuGhA-3Aza+k; Tue,  7 Jul 2009 10:15:41 +0200 (CEST)
Received: from ulanbator.act-europe.fr (ulanbator.act-europe.fr [10.10.1.67]) 	(using TLSv1 with cipher AES128-SHA (128/128 bits)) 	(No client certificate requested) 	by mel.act-europe.fr (Postfix) with ESMTP id 2B168290016; 	Tue,  7 Jul 2009 10:15:41 +0200 (CEST)
Cc: gdb-patches@sourceware.org
Message-Id: <C4869BB5-4314-47DD-AA04-7806DD37CE7A@adacore.com>
From: Tristan Gingold <gingold@adacore.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
In-Reply-To: <200907061016.n66AGPFQ000907@brahms.sibelius.xs4all.nl>
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v935.3)
Subject: Re: [RFA Darwin]: Add push_dummy_call for i386
Date: Tue, 07 Jul 2009 08:15:00 -0000
References: <20090703155152.GA76089@ulanbator.act-europe.fr> <200907031648.n63Gm7Wn019605@brahms.sibelius.xs4all.nl> <E3F432CF-F5DE-4D3C-8408-28048D7C7669@adacore.com> <200907061016.n66AGPFQ000907@brahms.sibelius.xs4all.nl>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-07/txt/msg00177.txt.bz2


On Jul 6, 2009, at 12:16 PM, Mark Kettenis wrote:
>> I quoted LowLevelABI.pdf.  What is wrong in this sentence ?  (Keep
>> in mind that I am not a native english speaker!)
>
> Heh well, if it is a quotation, better not change it.  But perhaps the
> comment should indicate this is a quotation from the ABI document?

I propose this:

   /* According to Mac OS X ABI document (passing arguments):
      6.  The caller places 64-bit vectors (__m64) on the parameter  
area,
          aligned to 8-byte boundaries.
      7.  [...]  The caller aligns 128-bit vectors in the parameter  
area to
          16-byte boundaries.  */


Is it OK with that change (or do you prefer to review the whole patch  
again) ?

Tristan.