Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: gingold@adacore.com
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA Darwin]: Add push_dummy_call for i386
Date: Mon, 06 Jul 2009 10:16:00 -0000	[thread overview]
Message-ID: <200907061016.n66AGPFQ000907@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <E3F432CF-F5DE-4D3C-8408-28048D7C7669@adacore.com> (message from 	Tristan Gingold on Mon, 6 Jul 2009 09:08:23 +0200)

> From: Tristan Gingold <gingold@adacore.com>
> Date: Mon, 6 Jul 2009 09:08:23 +0200
> 
> On Jul 3, 2009, at 6:48 PM, Mark Kettenis wrote:
> 
> >> + static int
> >> + i386_darwin_arg_type_alignment (struct type *type)
> >> + {
> >> +   type = check_typedef (type);
> >> +   /* Passing arguments.
> >> +      5.  The caller places 64-bit vectors (__m64) on the  
> >> parameter area,
> >> +          aligned to 8-byte boundaries.
> >
> > "on the parameter area"?  Probably a type.
> 
> I quoted LowLevelABI.pdf.  What is wrong in this sentence ?  (Keep
> in mind that I am not a native english speaker!)

Heh well, if it is a quotation, better not change it.  But perhaps the
comment should indicate this is a quotation from the ABI document?


  reply	other threads:[~2009-07-06 10:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-03 15:52 Tristan Gingold
2009-07-03 16:49 ` Mark Kettenis
2009-07-06  7:08   ` Tristan Gingold
2009-07-06 10:16     ` Mark Kettenis [this message]
2009-07-07  8:15       ` Tristan Gingold
2009-07-03 16:55 ` Joseph S. Myers
2009-07-06  7:00   ` Tristan Gingold
2009-07-04 15:31 ` H.J. Lu
2009-07-06  6:56   ` Tristan Gingold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200907061016.n66AGPFQ000907@brahms.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=gdb-patches@sourceware.org \
    --cc=gingold@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox