From: Tristan Gingold <gingold@adacore.com>
To: H.J. Lu <hjl.tools@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA Darwin]: Add push_dummy_call for i386
Date: Mon, 06 Jul 2009 06:56:00 -0000 [thread overview]
Message-ID: <4899FE33-4381-4755-BEA2-1824E6F6CE9F@adacore.com> (raw)
In-Reply-To: <6dc9ffc80907040831n1e87a80cv4d14afefc40dd687@mail.gmail.com>
On Jul 4, 2009, at 5:31 PM, H.J. Lu wrote:
> On Fri, Jul 3, 2009 at 8:51 AM, Tristan Gingold<gingold@adacore.com>
> wrote:
>> Hi,
>>
>> Darwin i386 ABI is slightly different from the SVR4 one. In
>> particular
>> stack alignment is 16. As a consquence, i386 Darwin can't use the
>> standard
>> i386-tdeo.c push_dummy_call and this patch provides a Darwin
>> version of this
>> call.
>>
>
> Well, the code generated by gcc for Linux/i386 assumes that the
> incoming
> stack is aligned at 16byte. If not, functions using SSE registers
> may crash.
Interesting, as I can't see the code that preserve stack alignment in
i386-tdep.c
Anyway, i386/Darwin needs to have its own push_dummy_call code as it
doesn't follow
that SVR4 ABI on many points.
Tristan.
prev parent reply other threads:[~2009-07-06 6:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-03 15:52 Tristan Gingold
2009-07-03 16:49 ` Mark Kettenis
2009-07-06 7:08 ` Tristan Gingold
2009-07-06 10:16 ` Mark Kettenis
2009-07-07 8:15 ` Tristan Gingold
2009-07-03 16:55 ` Joseph S. Myers
2009-07-06 7:00 ` Tristan Gingold
2009-07-04 15:31 ` H.J. Lu
2009-07-06 6:56 ` Tristan Gingold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4899FE33-4381-4755-BEA2-1824E6F6CE9F@adacore.com \
--to=gingold@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox