From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27620 invoked by alias); 6 Jul 2009 06:56:45 -0000 Received: (qmail 27612 invoked by uid 22791); 6 Jul 2009 06:56:44 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (212.99.106.210) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 06 Jul 2009 06:56:35 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 09E0A29004C; Mon, 6 Jul 2009 08:56:32 +0200 (CEST) Received: from mel.act-europe.fr ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vBORlPsGccn9; Mon, 6 Jul 2009 08:56:31 +0200 (CEST) Received: from province.act-europe.fr (province.act-europe.fr [10.10.0.214]) by mel.act-europe.fr (Postfix) with ESMTP id 658CA290025; Mon, 6 Jul 2009 08:56:31 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by filtered-province.act-europe.fr (Postfix) with ESMTP id 407FF166523; Mon, 6 Jul 2009 08:56:31 +0200 (CEST) Received: from province.act-europe.fr ([127.0.0.1]) by localhost (province.act-europe.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id l-WVdIlqFy4L; Mon, 6 Jul 2009 08:56:31 +0200 (CEST) Received: from [IPv6:::1] (province.act-europe.fr [10.10.0.214]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by province.act-europe.fr (Postfix) with ESMTPSA id D523C166529; Mon, 6 Jul 2009 08:56:30 +0200 (CEST) Cc: gdb-patches@sourceware.org Message-Id: <4899FE33-4381-4755-BEA2-1824E6F6CE9F@adacore.com> From: Tristan Gingold To: H.J. Lu In-Reply-To: <6dc9ffc80907040831n1e87a80cv4d14afefc40dd687@mail.gmail.com> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v935.3) Subject: Re: [RFA Darwin]: Add push_dummy_call for i386 Date: Mon, 06 Jul 2009 06:56:00 -0000 References: <20090703155152.GA76089@ulanbator.act-europe.fr> <6dc9ffc80907040831n1e87a80cv4d14afefc40dd687@mail.gmail.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-07/txt/msg00125.txt.bz2 On Jul 4, 2009, at 5:31 PM, H.J. Lu wrote: > On Fri, Jul 3, 2009 at 8:51 AM, Tristan Gingold > wrote: >> Hi, >> >> Darwin i386 ABI is slightly different from the SVR4 one. In >> particular >> stack alignment is 16. As a consquence, i386 Darwin can't use the >> standard >> i386-tdeo.c push_dummy_call and this patch provides a Darwin >> version of this >> call. >> > > Well, the code generated by gcc for Linux/i386 assumes that the > incoming > stack is aligned at 16byte. If not, functions using SSE registers > may crash. Interesting, as I can't see the code that preserve stack alignment in i386-tdep.c Anyway, i386/Darwin needs to have its own push_dummy_call code as it doesn't follow that SVR4 ABI on many points. Tristan.