Re: [PATCH] Remove unused str_backtrace_unavailable variable

["Machado, Luis" <Luis.Machado@amd.com>]

Thanks for the heads up on Insight. For context, this came up when using llvm.

It got grumpy about the unused-but-initialized value.

________________________________________
From: Tom Tromey <tom@tromey.com>
Sent: Friday, 1 May 2026 16:50
To: Simon Marchi
Cc: Machado, Luis; gdb-patches@sourceware.org
Subject: Re: [PATCH] Remove unused str_backtrace_unavailable variable

Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.


>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

Simon> Seems quite obvious to me, but I would wait for Andrew to confirm that
Simon> this wasn't meant to be used somewhere.  For instance, in the
Simon> libbacktrace_error function.  But I think the message there is clear, so
Simon> I'd be fine with just deleting the variable.

I considered this before approving but my view is that if it is needed,
it is trivial to revert a deletion like this.

I'd generally consider the removal of an unused object to be obvious,
with the caveats:

1. If it looks like maybe it *ought* to be used, then send an RFA
   instead;
2. Be sure to check Insight as it uses a few things that are otherwise
   unused.

Tom