Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: Luis Machado <luis.machado@amd.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Remove unused str_backtrace_unavailable variable
Date: Fri, 1 May 2026 10:17:11 -0400	[thread overview]
Message-ID: <05b178cb-724e-44ce-bbd8-8587aa87ca17@simark.ca> (raw)
In-Reply-To: <20260501073117.2962398-1-luis.machado@amd.com>

On 5/1/26 3:31 AM, Luis Machado wrote:
> The str_backtrace_unavailable variable is initialized but never
> used anywhere in the codebase.
> ---
>  gdb/bt-utils.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/gdb/bt-utils.c b/gdb/bt-utils.c
> index 7fc8d04f306..21a291c3df3 100644
> --- a/gdb/bt-utils.c
> +++ b/gdb/bt-utils.c
> @@ -146,7 +146,6 @@ gdb_internal_backtrace_1 ()
>  #endif
>  
>  static const char *str_backtrace = "----- Backtrace -----\n";
> -static const char *str_backtrace_unavailable = "Backtrace unavailable\n";
>  
>  #endif /* GDB_PRINT_INTERNAL_BACKTRACE */
>  
> @@ -157,7 +156,6 @@ gdb_internal_backtrace_init_str ()
>  {
>  #ifdef GDB_PRINT_INTERNAL_BACKTRACE
>    str_backtrace = _("----- Backtrace -----\n");
> -  str_backtrace_unavailable = _("Backtrace unavailable\n");
>  #endif
>  }

Seems quite obvious to me, but I would wait for Andrew to confirm that
this wasn't meant to be used somewhere.  For instance, in the
libbacktrace_error function.  But I think the message there is clear, so
I'd be fine with just deleting the variable.

Simon

  parent reply	other threads:[~2026-05-01 14:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-01  7:31 Luis Machado
2026-05-01 12:59 ` Tom Tromey
2026-05-01 14:17 ` Simon Marchi [this message]
2026-05-01 14:20   ` Luis
2026-05-01 15:50   ` Tom Tromey
2026-05-01 15:58     ` Machado, Luis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05b178cb-724e-44ce-bbd8-8587aa87ca17@simark.ca \
    --to=simark@simark.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=luis.machado@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox