Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Luis Machado <luis.machado@amd.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH] Remove unused str_backtrace_unavailable variable
Date: Fri, 01 May 2026 09:50:05 -0600	[thread overview]
Message-ID: <87bjezi0ya.fsf@tromey.com> (raw)
In-Reply-To: <05b178cb-724e-44ce-bbd8-8587aa87ca17@simark.ca> (Simon Marchi's message of "Fri, 1 May 2026 10:17:11 -0400")

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

Simon> Seems quite obvious to me, but I would wait for Andrew to confirm that
Simon> this wasn't meant to be used somewhere.  For instance, in the
Simon> libbacktrace_error function.  But I think the message there is clear, so
Simon> I'd be fine with just deleting the variable.

I considered this before approving but my view is that if it is needed,
it is trivial to revert a deletion like this.

I'd generally consider the removal of an unused object to be obvious,
with the caveats:

1. If it looks like maybe it *ought* to be used, then send an RFA
   instead;
2. Be sure to check Insight as it uses a few things that are otherwise
   unused.

Tom

  parent reply	other threads:[~2026-05-01 15:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-01  7:31 Luis Machado
2026-05-01 12:59 ` Tom Tromey
2026-05-01 14:17 ` Simon Marchi
2026-05-01 14:20   ` Luis
2026-05-01 15:50   ` Tom Tromey [this message]
2026-05-01 15:58     ` Machado, Luis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bjezi0ya.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=luis.machado@amd.com \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox