From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4fu1LMzL9GksQQkAWB0awg (envelope-from ) for ; Fri, 01 May 2026 11:50:36 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=qVWFD+Pz; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B26BC1E0BA; Fri, 01 May 2026 11:50:36 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id F0B0E1E067 for ; Fri, 01 May 2026 11:50:35 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 8852644115C8 for ; Fri, 1 May 2026 15:50:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8852644115C8 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=qVWFD+Pz Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id 801A843B5503 for ; Fri, 1 May 2026 15:50:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 801A843B5503 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 801A843B5503 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777650608; cv=none; b=dhy5MfNMCtwnA+kAb4HGucMnanKsk402abaw/U2XfLtD0wmg6ZsxHPl+Qu+O3Wy4o5m7xB3HlG1d9YpCIE+Nb4Vbil3VGagFHSt+yUnZC5szUgE0ykvGeyqy2CEO8p0yWkCfr/yTEB590zIhsT3F2zDV4IwGopnukNO1K/d6uug= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777650608; c=relaxed/simple; bh=yXXyemJ84DLKj3FLvBZcY5uS2Tn8sTDq+8uLgA6obDg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=QEAPTwi+w5YU6jQcBkwAitB7z24OOK+yCIM7Bs1ZzT2iAQv48lmesqWG3p9s3aX9s4rd4neZuDkvJPPyqgU1mNiIRPirYr2t26ovJZfAXPl9Z1PAX7EDgnmK1BK9KuiVECO5B4E0oGu/Ro5v9aRTeZuWQny3ABo5HZMQbKJA9fU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 801A843B5503 Received: from eig-obgw-6002b.ext.cloudfilter.net ([10.0.30.203]) by cmsmtp with ESMTPS id IZQTw4cypnfzsIq7zwfqFq; Fri, 01 May 2026 15:50:07 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id Iq7zw5TXfbONDIq7zw9hEa; Fri, 01 May 2026 15:50:07 +0000 X-Authority-Analysis: v=2.4 cv=XdKJzJ55 c=1 sm=1 tr=0 ts=69f4cbaf a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=NGcC8JguVDcA:10 a=ItBw4LHWJt0A:10 a=dzWzf_mpAAAA:8 a=QnueGHXJCQJaHq1uOtQA:9 a=zZCYzV9kfG8A:10 a=b4DR9a7p2ZdsqdHBznES:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=S2/HziolXNTnOjROw08TsNTQaTsOBt8+OStna6l9Q3M=; b=qVWFD+Pz8BkLr9FhZjRxU9pVDZ 6TSmHLKHWqWHRS5hjw+XCNa2MAljAwWlYTXUfxSspKYJQucvtM/RGeIqRAm41AhuxR+88XoA2XPxA S1l31pEwB0BtD1/09a5vAtpgD; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:39358 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wIq7z-00000000NXK-0wPG; Fri, 01 May 2026 09:50:06 -0600 From: Tom Tromey To: Simon Marchi Cc: Luis Machado , gdb-patches@sourceware.org Subject: Re: [PATCH] Remove unused str_backtrace_unavailable variable In-Reply-To: <05b178cb-724e-44ce-bbd8-8587aa87ca17@simark.ca> (Simon Marchi's message of "Fri, 1 May 2026 10:17:11 -0400") References: <20260501073117.2962398-1-luis.machado@amd.com> <05b178cb-724e-44ce-bbd8-8587aa87ca17@simark.ca> X-Attribution: Tom Date: Fri, 01 May 2026 09:50:05 -0600 Message-ID: <87bjezi0ya.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wIq7z-00000000NXK-0wPG X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:39358 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfDfZ9BuLLbXIucD1V7ONUVhajCZqLuqHFqBKg6E2su6+AHG3CSP7pCMw2JXUxbNBkde5aEkdL7qPKafsKmfZUav7Y/Tvemahrxly53uQGjKo2aAZ2iVh 9Uk7VQjOYYnWzYNmVklqIXmf2AlxHOSYcN7q94tqxCjjnvoB2x8FU1zTDjKdxl1ob8aBQ77exlJx2aW8xBybIXEQS3hEO3Y3teA= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> Seems quite obvious to me, but I would wait for Andrew to confirm that Simon> this wasn't meant to be used somewhere. For instance, in the Simon> libbacktrace_error function. But I think the message there is clear, so Simon> I'd be fine with just deleting the variable. I considered this before approving but my view is that if it is needed, it is trivial to revert a deletion like this. I'd generally consider the removal of an unused object to be obvious, with the caveats: 1. If it looks like maybe it *ought* to be used, then send an RFA instead; 2. Be sure to check Insight as it uses a few things that are otherwise unused. Tom