From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id s6vjGwW29GmNKQkAWB0awg (envelope-from ) for ; Fri, 01 May 2026 10:17:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1777645061; bh=O38DmqWtefu5NUcymDwsbQkcIXMLbeKbeqH22k7Ul7s=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=hNmKOkpI7Cz61ItE4qqx6rvqvSQ+8blQqlpB+67sUmJF3zUizBDqJlX57X9YriCbJ u8BUhTLm8HZ4OnYs/VR6MvEiSP21oRhVQ/MERLgYo9FHiBTo4Lfye5jcwlSu4j2NJQ c1oBPqPatuzCC1x7YlXYkg9eRwGP9DeJ5UgA2wu0= Received: by simark.ca (Postfix, from userid 112) id 5E28E1E0BA; Fri, 01 May 2026 10:17:41 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=XsJrL7cB; dkim-atps=neutral Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6B2181E067 for ; Fri, 01 May 2026 10:17:39 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 8C91946A9CF3 for ; Fri, 1 May 2026 14:17:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8C91946A9CF3 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=XsJrL7cB Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 644B746A9CEA for ; Fri, 1 May 2026 14:17:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 644B746A9CEA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 644B746A9CEA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777645034; cv=none; b=nxZa5AE44AizUR7vfQm331IlZVFpwD/1lXxFlJjjo/xfY12h2rzJs8eFC/9vhhCElf2EQkymC3HJITrnkHsTta9M4NtDGFFvPqlGRlBHKCCIOoJMsnMsjfmfpBbVuo6Tjglxhm8qWPEaD35m+U00n0ZAOzGl7xYxvrmGsi5TtMk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1777645034; c=relaxed/simple; bh=O38DmqWtefu5NUcymDwsbQkcIXMLbeKbeqH22k7Ul7s=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=eb3i8JhTBqUsvRz1KOOJ3tIiAltDo4SW6BiqrptAqiUHutaA9aQuIg9bBnR79b2umr0cdBWKgBpO2iapsjv8/StyYvA9A7TS25tQ4G5oPLzMtb0EGJ8Px1KCyWZnVxOCkJMxuT5XBX0tti7J+cPtvcF88vywCltsFDW58NSzPDI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 644B746A9CEA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1777645032; bh=O38DmqWtefu5NUcymDwsbQkcIXMLbeKbeqH22k7Ul7s=; h=Date:Subject:To:References:From:In-Reply-To:From; b=XsJrL7cBjuYK4e0T6wNE8IjuSav2Qe/5qbn6XOPU26u7dO6WwsHZnp7W5nY7JkfE9 10iR0AYt/DXb1I6ER1231P5y7EZW/okBd8LvPneycfq08yzrGU1DWRbl13P9Eg96Mi xck+4atZOzWOoCsWES+nkwHwjzHNyJI9EZjOJKV0= Received: by simark.ca (Postfix) id 839E11E067; Fri, 01 May 2026 10:17:11 -0400 (EDT) Message-ID: <05b178cb-724e-44ce-bbd8-8587aa87ca17@simark.ca> Date: Fri, 1 May 2026 10:17:11 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Remove unused str_backtrace_unavailable variable To: Luis Machado , gdb-patches@sourceware.org References: <20260501073117.2962398-1-luis.machado@amd.com> Content-Language: fr From: Simon Marchi In-Reply-To: <20260501073117.2962398-1-luis.machado@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 5/1/26 3:31 AM, Luis Machado wrote: > The str_backtrace_unavailable variable is initialized but never > used anywhere in the codebase. > --- > gdb/bt-utils.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/gdb/bt-utils.c b/gdb/bt-utils.c > index 7fc8d04f306..21a291c3df3 100644 > --- a/gdb/bt-utils.c > +++ b/gdb/bt-utils.c > @@ -146,7 +146,6 @@ gdb_internal_backtrace_1 () > #endif > > static const char *str_backtrace = "----- Backtrace -----\n"; > -static const char *str_backtrace_unavailable = "Backtrace unavailable\n"; > > #endif /* GDB_PRINT_INTERNAL_BACKTRACE */ > > @@ -157,7 +156,6 @@ gdb_internal_backtrace_init_str () > { > #ifdef GDB_PRINT_INTERNAL_BACKTRACE > str_backtrace = _("----- Backtrace -----\n"); > - str_backtrace_unavailable = _("Backtrace unavailable\n"); > #endif > } Seems quite obvious to me, but I would wait for Andrew to confirm that this wasn't meant to be used somewhere. For instance, in the libbacktrace_error function. But I think the message there is clear, so I'd be fine with just deleting the variable. Simon