From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KZvZF8PN9GmGQwkAWB0awg (envelope-from ) for ; Fri, 01 May 2026 11:58:59 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=X5ZhB+0W; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5C9B21E067; Fri, 01 May 2026 11:58:59 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E730D1E067 for ; Fri, 01 May 2026 11:58:58 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 7A17F46A9CEB for ; Fri, 1 May 2026 15:58:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7A17F46A9CEB Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=X5ZhB+0W Received: from CY3PR05CU001.outbound.protection.outlook.com (mail-westcentralusazlp170130007.outbound.protection.outlook.com [IPv6:2a01:111:f403:c112::7]) by sourceware.org (Postfix) with ESMTPS id 575D34A9A79E for ; Fri, 1 May 2026 15:58:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 575D34A9A79E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 575D34A9A79E Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c112::7 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1777651113; cv=pass; b=acTdLR8b6m9VuQBvDidn7mYU3k/9oqAVzFxHKgLjdPK7noBpgQhKX3C/K8cWV+UIdezleUCBrSubwJ6XXp7qJAhp0i4rVQL3NyNxzmiFPn+g6Lssx4pIAgZS2k/P8ssPFvg32ntWWC6QgNw3XEfd+OE7zzqjbrsS3vveyXG63PU= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1777651113; c=relaxed/simple; bh=g9SwZAfZUVIPm0kVdi9n/AY/X4+kZc8gy1uKrBofm5M=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=cGG1c+50HxJjN/wUknQ3QKSSrnlLgaZpgLYjrv3sNF67VUFkE07caQm8+G7eqKYgbetossB326Aa81VAk4aXRy1SzAscyZQUe4hTOICl+CpU8nP7WGQfY4Y8KA1EVKQz/JENvL3Cs4S6A6rpV1rBxqZ0/Z2RiDJXp7RTto7k5Iw= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 575D34A9A79E ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iAEbdfwcCEzOR/XXfyk6glLwjkVBFRvcCWNPZhIqcK5EA1LRdmY2WK4GTRTlrSD2QT3MNEmJ0/O5zcJvjGXgHVUeB6FkoPTkXlJOb8eB0wAW+DqdOhZriggcYxXOJjdvr84T05kHXA7GphNEga3csITlqb9VKOKAB1u2ZgBXu3NHoryneTXpV4vwytpe8LDr1axVOrpp6f9jaGJPky+ytqu3NqpVFdnzXpwTW3mK7buAGtTiKmysfyN2tX1nIh2yDYUIGN0wXiHnmdz2rmO38W1aTbGYdHV22Sdu1rz03Ug4cmkC3Rdeju+Zyxidko7/sigdQ64ywjnrapm5vOrpKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6/EvgV8bxY4WQ61xnPuOVSFAS3T4zxnL3oEJE+rHbww=; b=wAVwXJ4Eb7CESo2Ywn0X7v4cHHk6lq8uZAFLhq5rYwUD5CqEph5u/qlkCm/djbhc6czmE9RZ1f91RgvHJKKL52v5BWdcQv3nSQoDRPOu+fU04gZge3yjYy2gDBWav0F3hhL3BfdcpEKUvLc6gfFsDk5k9s8Bbe5uaGXIIXAowDxfNdmkOZaALcnHXG65Vzf1aRM8ywarVWG8IQLARXkotAULJY6iqvEKf3Em/5PwxgZOqpGhJ0TR573hUZmPXOeibOyzKdQiQ01gfQPZpg3zETcZ/dpgnyt774sgjEnwS+3UDsg1WrthpKbsVI7iDsII8NtvwI2tQF/uwn+NkiGHRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6/EvgV8bxY4WQ61xnPuOVSFAS3T4zxnL3oEJE+rHbww=; b=X5ZhB+0WCLhdi3TI5F3w/phQVm6ei7TswvtwHrHZ+T9iDWlqh+bjcUkctlj4y9KWxhkVj3Lm5mXWY4TdmX1rEjQ+tK4tr5G/gsDa1PrRed1yBWyKZWWjL/2MCMWar/2U1/q4iVIdpcJl2/5qxdubC3yqID3ms1ckxFMrZr+2bLE= Received: from BN7PPF915F74166.namprd12.prod.outlook.com (2603:10b6:40f:fc02::6d9) by SA1PR12MB7197.namprd12.prod.outlook.com (2603:10b6:806:2bd::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9870.22; Fri, 1 May 2026 15:58:28 +0000 Received: from BN7PPF915F74166.namprd12.prod.outlook.com ([fe80::b894:7b3:c5bc:b0b0]) by BN7PPF915F74166.namprd12.prod.outlook.com ([fe80::b894:7b3:c5bc:b0b0%5]) with mapi id 15.20.9870.013; Fri, 1 May 2026 15:58:28 +0000 From: "Machado, Luis" To: Tom Tromey , Simon Marchi CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH] Remove unused str_backtrace_unavailable variable Thread-Topic: [PATCH] Remove unused str_backtrace_unavailable variable Thread-Index: AQHc2TyUZTBhjH9Sf0y740OPqgkfJ7X5N+2AgAAZ/9qAAAHsLg== Date: Fri, 1 May 2026 15:58:28 +0000 Message-ID: References: <20260501073117.2962398-1-luis.machado@amd.com> <05b178cb-724e-44ce-bbd8-8587aa87ca17@simark.ca> <87bjezi0ya.fsf@tromey.com> In-Reply-To: <87bjezi0ya.fsf@tromey.com> Accept-Language: en-150, en-US Content-Language: aa X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Enabled=True; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_SetDate=2026-05-01T15:58:27.460Z; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Name=AMD Internal Distribution Only; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_ContentBits=1; MSIP_Label_dce362fe-1558-4fb5-9f64-8a6240d76441_Method=Standard; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN7PPF915F74166:EE_|SA1PR12MB7197:EE_ x-ms-office365-filtering-correlation-id: 458ca607-ae90-444c-be3f-08dea79a7c2a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|376014|1800799024|56012099003|18002099003|22082099003|38070700021; x-microsoft-antispam-message-info: oFcCxapI3UytKmEfvjUZBiC8Skg7nndN8RQh0NP/+7dGY/Ft5lQzWaEYsNIFnskcXHQR6WQLXbZ7sn6RdetaupnmRTyCzo9X3D6BWqs/HlLuwt0lzh02d/ucu0ZXzhPjJTWnpArMIRlqIiyebH6v9/RY5922a0zE015OyMfpn6BaFOLsOI6uz2Ha5GqqxjsngLgyLB/ewLHHIu2evUVorJTMXpHA6ZxEfcL6B+kEZC1a65lNGqOmbhCLzTM+GkCeuxXjjUrgd5TekBQrsBJbPpizEQtWSJY33JGVCTTKQVh63FQw4CMvwToJ1jkCrX6caB/P8fD+hoOWGJyojRy9uekBjOby4A/VRP5zTOV9E5684Z9iILyCSkEVOloRJXi3iJ+UZIIu0jAbmAEjOuEWC+3ZN6BL/eAK/1zH0QBVA9DB3Rj8LAFA2KDy3dGzgJ7JFbx2yRthAjAsRF3LGjVZ9SgLoNyauBARK8rtkh4wYFY2QH3w+KU5wGtJLkrqcKYYSKbjq+LKKKW5o4j39sOYKRX4HKvJYYtsIDC7HhU0ClFTsAm9iXeVxGwHUSXv30RCSLAPMZyq8VaV3hrI0b8kxxmjd6Kzw+cr4LRn8plpKIEQP8LZISdULc2L22db/2mbbatYv1ZaJ9Xp4YD6HmVkh0G5Wij08QePDOwM31EakadEsKHiHpBNzVHJ/IOMIu3RdelowpnOsIxG7UGAeQFeFyDiUAOTf+NZ96/Su3RHfVRnZ0O+anv4XVFnT2kqxr32 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN7PPF915F74166.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024)(56012099003)(18002099003)(22082099003)(38070700021); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?F2heGePzciM052nNqj2laoSijnqkp25vomNbw5eUoocYocfbOEK1MdgtLMns?= =?us-ascii?Q?Qwk+3Fq8Gdw7YPg/SKGWEXVc6Zo7PG0ASPF4I+OeGorVzFO8nhiFE6NmlOt1?= =?us-ascii?Q?HjUO/RfN5PSeOaneLmcuyYniodCtnqvX8b61ahaIdsYV3ZOys1mMnPq60iXd?= =?us-ascii?Q?1JdgC6vH88x+cw12XKqSh1kLox5EH1/3BErraKh+GFZQrJ0u95P5ibT1HKh9?= =?us-ascii?Q?Nua1anYsf2lzv327ztGpfLDhssv+RqMiKnTwCH16arB+KO8znv29szjTQAQk?= =?us-ascii?Q?mzLEVl5rI8+ut8eAicLNjz3uYZHPIPQ9YSSFt5LqhO4d03UtEdD5chHifx9a?= =?us-ascii?Q?BRZDdCAO2nweLNQQE6cIlQDzvBHhW4RLsIBFDAduvRPi74YaOvdfBQzTZLrt?= =?us-ascii?Q?v0+XYcHQI6/DkGTVl69JJPrE6LLAtupKrGj3u0WrcgAbHsFA3FFKypgdg0ls?= =?us-ascii?Q?hCApyWrVaKDJYdhPUkq3Yt/jJ/9OpFNemnZKL1e/+hWLSBQIz/Pli/A5gARq?= =?us-ascii?Q?i55BctmWgWEvkYaAoubqfO12jzksn8WiZKTnAlLJ9gQFx0g/vD2+Rg4RE33u?= =?us-ascii?Q?itUyvR+jxw7OoG8jENGqNm20UvL33jrA6FF9V93qukqVowD5zafTukFJVeBC?= =?us-ascii?Q?EDtrl4lLtEXHcjTrnx/nZAZGe7fesja6/9ElueH+zLWaFfLy0AEo6sxWWj0L?= =?us-ascii?Q?1SsZNe33gde4bdF6kku1vSa1mpTLPIqj7JWCXD+AjRBiNGws9zPx8EEDZNa7?= =?us-ascii?Q?PbdVul/gqYYM40zoxYTrCSpTTzsUwdfvsTxVnD3vUVVYA77eqYa/FEGjQwhv?= =?us-ascii?Q?8F5FHyeUIcqJ+sCSX5gWFzKGjJdYjmYxRvUE3vI0tzcyTpkj2QmPP3e5m8ms?= =?us-ascii?Q?zfwDIUrZy2P1tyjfsMmnL/ErwuqEsm2ztDNo/12KnMxGnUD+2k5kqeNrJYBy?= =?us-ascii?Q?GF4Roc+nmIGi4djiev9x+u9YbKg+xMDPNYtNwUUc4pLYg91sWmxsFYGMWBMw?= =?us-ascii?Q?iWH9w7IFQCTuI4NiX6c14Jr/D7Zl2nndfhqQ/A9G/OfxSuxTCbYzfWrLia9a?= =?us-ascii?Q?oM3hVnSZfnVVDqoqIshqPu7DHSFmdOqZJEF9iakMzSermQa0sAUVbGFlmDk1?= =?us-ascii?Q?EokuN/c3aVOv7iqef3l166So5r02/zEnBXC2vSC/s+YmQjv2xxqFuEVmShFE?= =?us-ascii?Q?JEYHD/YlWXjxM2vHFA5Y/mvOCNK2zfQF42npHeX+Ws8MlYIgdQk6eL31Qy4o?= =?us-ascii?Q?+Ed0cy1UHmu5QptCzDuPImUoFlYaiD78xtCA0NYbu80FG06lI5G8PqwEXv12?= =?us-ascii?Q?h9zPa7NCohF2BEaRDvvqJCnZnpyb1mCHKTlkKtbSqtF5QMPVrS511T5xURZf?= =?us-ascii?Q?cmJ+h+ETRUHfdiM8o1/SGGnyPqvbIqPpwBW8TCqhxJG4/SMtjfWFXk00VUIw?= =?us-ascii?Q?pvOV/uBla4BAyCIXVeesGNndfb/E+6y4yri5mijBBDhMyhtFaaASfXtdDctN?= =?us-ascii?Q?10WBDMzaVPkJ4rHjty9PtgW1/OJzxHIh0L+ETv9qzUgSmW2ypDAvehudg06H?= =?us-ascii?Q?/KnOO2vDg/Pr4uAlU4KwJZ7x6DeS6kz7LfF4n8/KwMXgLe9rhtHMpNmYS4qL?= =?us-ascii?Q?wjhUsXd8ydZ1TV+wKNuJXu0MRpKFrDgE/KskCSvYXszP+baGa5VYPJ+xTZCe?= =?us-ascii?Q?KKq0MtYTQ9fNfvsbsSSAdYTeSP8qKGogyxGfHs9X03Ial28V?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN7PPF915F74166.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 458ca607-ae90-444c-be3f-08dea79a7c2a X-MS-Exchange-CrossTenant-originalarrivaltime: 01 May 2026 15:58:28.2593 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: naWC9lEzwbGfxv524aSxmbC35WdiVYl5KUeLlYiGL1lpJvMcNzVS5r8E2Y75JokWuAwgmHuV923tkr4RJKdBYg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7197 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Thanks for the heads up on Insight. For context, this came up when using ll= vm.=0A= =0A= It got grumpy about the unused-but-initialized value.=0A= =0A= ________________________________________=0A= From: Tom Tromey =0A= Sent: Friday, 1 May 2026 16:50=0A= To: Simon Marchi=0A= Cc: Machado, Luis; gdb-patches@sourceware.org=0A= Subject: Re: [PATCH] Remove unused str_backtrace_unavailable variable=0A= =0A= Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding.=0A= =0A= =0A= >>>>> "Simon" =3D=3D Simon Marchi writes:=0A= =0A= Simon> Seems quite obvious to me, but I would wait for Andrew to confirm th= at=0A= Simon> this wasn't meant to be used somewhere. For instance, in the=0A= Simon> libbacktrace_error function. But I think the message there is clear= , so=0A= Simon> I'd be fine with just deleting the variable.=0A= =0A= I considered this before approving but my view is that if it is needed,=0A= it is trivial to revert a deletion like this.=0A= =0A= I'd generally consider the removal of an unused object to be obvious,=0A= with the caveats:=0A= =0A= 1. If it looks like maybe it *ought* to be used, then send an RFA=0A= instead;=0A= 2. Be sure to check Insight as it uses a few things that are otherwise=0A= unused.=0A= =0A= Tom=0A=