From: Ciaran Woodward <ciaranwoodward@xmos.com>
To: Tom Tromey <tom@tromey.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH 1/1] gdb/tui: Fix build for older ncurses
Date: Fri, 12 Sep 2025 17:17:07 +0000 [thread overview]
Message-ID: <AS8PR09MB5303C3060F2E82B0603B289FB908A@AS8PR09MB5303.eurprd09.prod.outlook.com> (raw)
In-Reply-To: <878qijogpi.fsf@tromey.com>
> Would you mind adding a comment here explaining the need for the cast
> and also for which version of curses it was found to be needed?
> I think that may help future developers.
>
> Anyway ok with this change.
> Approved-By: Tom Tromey <tom@tromey.com>
Thanks - added the comment & pushed.
next prev parent reply other threads:[~2025-09-12 17:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-11 18:30 Ciaran Woodward
2025-09-12 15:04 ` Tom Tromey
2025-09-12 17:17 ` Ciaran Woodward [this message]
2026-07-27 16:15 ` Daniel Fellows
2026-07-28 13:29 ` Ciaran Woodward
2026-07-28 13:38 ` Daniel Fellows
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AS8PR09MB5303C3060F2E82B0603B289FB908A@AS8PR09MB5303.eurprd09.prod.outlook.com \
--to=ciaranwoodward@xmos.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox