From: Ciaran Woodward <ciaranwoodward@xmos.com>
To: Daniel Fellows <daniel.fellows@arm.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"tom@tromey.com" <tom@tromey.com>, "nd@arm.com" <nd@arm.com>
Subject: RE: [PATCH 1/1] gdb/tui: Fix build for older ncurses
Date: Tue, 28 Jul 2026 13:29:01 +0000 [thread overview]
Message-ID: <MI3PR09MB8624C424FF3F0BDF7DF0E063B9CB2@MI3PR09MB8624.eurprd09.prod.outlook.com> (raw)
In-Reply-To: <20260727161531.1035805-1-daniel.fellows@arm.com>
> -----Original Message-----
> From: Daniel Fellows <daniel.fellows@arm.com>
> Sent: 27 July 2026 17:16
>
> Would you be willing to backport this fix to gdb-17-branch?
>
> We encountered the A_ITALIC build failure after moving our macOS builds
> to GDB 17. I tested the fix successfully on both Intel and Arm macOS
> hosts.
>
> There is a small conflict with commit 07e542a3bd05, which added MinGW
> handling in the same section of ui-style.c. The resolution is to retain
> that MinGW block alongside your tgetnum change.
Hi Daniel,
I'm happy for this fix to be backported, and I'm happy to push the commit
if you aren't able - from my perspective it seems extremely low risk.
I'm not quite sure on the backport process - I assume it needs approval by
a maintainer, at least.
Can any maintainer fill us in?
Cheers,
Ciaran
next prev parent reply other threads:[~2026-07-28 13:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-11 18:30 Ciaran Woodward
2025-09-12 15:04 ` Tom Tromey
2025-09-12 17:17 ` Ciaran Woodward
2026-07-27 16:15 ` Daniel Fellows
2026-07-28 13:29 ` Ciaran Woodward [this message]
2026-07-28 13:38 ` Daniel Fellows
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MI3PR09MB8624C424FF3F0BDF7DF0E063B9CB2@MI3PR09MB8624.eurprd09.prod.outlook.com \
--to=ciaranwoodward@xmos.com \
--cc=daniel.fellows@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=nd@arm.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox