Re: [PATCH 1/1] gdb/tui: Fix build for older ncurses

[Tom Tromey <tom@tromey.com>]

>>>>> "Ciaran" == Ciaran Woodward <ciaranwoodward@xmos.com> writes:

Ciaran> Older versions of ncurses (including the version that ships inside
Ciaran> macos, and Centos 7) do not include the A_ITALIC macro. This patch
Ciaran> simply hides any use of A_ITALIC behind a preprocessor guard.

Thanks for doing this.

Ciaran> The result of this is that italics won't be rendered in the tui
Ciaran> if ncurses isn't supported. We do have other options if we think
Ciaran> it's important - for instance we could show italics as bold if
Ciaran> italics aren't supported. From my understanding, that might be
Ciaran> overthinking it - so I took the simplest approach here, just to
Ciaran> fix the build.

Seems reasonable enough.

Ciaran> Those versions also define tgetnum as:
Ciaran>   int tgetnum(char *id);
Ciaran> so attempting to compile for c++ results in the error:
Ciaran>   ISO C++ forbids converting a string constant to 'char*' [-Werror=write-strings]

Ciaran> diff --git a/gdb/ui-style.c b/gdb/ui-style.c
Ciaran> index 9a58e4dd2ae..ccc9094ca59 100644
Ciaran> --- a/gdb/ui-style.c
Ciaran> +++ b/gdb/ui-style.c
Ciaran> @@ -594,7 +594,7 @@ colorsupport ()
Ciaran>      {
Ciaran>        std::vector<color_space> result = {color_space::MONOCHROME};
 
Ciaran> -      int colors = tgetnum ("Co");
Ciaran> +      int colors = tgetnum (const_cast<char*> ("Co"));

Would you mind adding a comment here explaining the need for the cast
and also for which version of curses it was found to be needed?
I think that may help future developers.

Anyway ok with this change.
Approved-By: Tom Tromey <tom@tromey.com>

Tom