From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0fhLE7dWxGhCswEAWB0awg (envelope-from ) for ; Fri, 12 Sep 2025 13:21:59 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=xmos1.onmicrosoft.com header.i=@xmos1.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-xmos1-onmicrosoft-com header.b=SH6Iaz9n; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4BF7B1E04C; Fri, 12 Sep 2025 13:21:59 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C3CA41E04C for ; Fri, 12 Sep 2025 13:21:58 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 58B713857C5F for ; Fri, 12 Sep 2025 17:21:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 58B713857C5F Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=xmos1.onmicrosoft.com header.i=@xmos1.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-xmos1-onmicrosoft-com header.b=SH6Iaz9n Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11020125.outbound.protection.outlook.com [52.101.69.125]) by sourceware.org (Postfix) with ESMTPS id 696C63858D21 for ; Fri, 12 Sep 2025 17:17:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 696C63858D21 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=xmos.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xmos.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 696C63858D21 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=52.101.69.125 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1757697435; cv=pass; b=JezdS2pLSHinq//DP8RcdzIl5z8K+tZn7IhFrjxbTefB5fX0a+65Z6QG2aLV2aFEmvPYxUGLWRc/MH2gZgS8OZQJBR/HODLNaWp23to4JAXWtjRm0aJiy6OwHM6pce8wbrVfi1GeTmy3u6HqNBfmowlp5oWpmj3HVmH5NfBPuYI= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1757697435; c=relaxed/simple; bh=auQOknieEknrNuPX+5kyTy6W8GHtdGQI5UO/6Sh2yWg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ZYdK+HprNc3mRhljIYvSoAdTClxRVY0ehvsml7dJku7JrKtnRM+E38vUQNKka45CHd1W3XOZE8BbnAQQu/HSUBseXiCbjoxe0xpZWJAwGCRMUh8VpNdZVoON2TSpY6zMg357VcQc7JvfUhK5p0vTF01fqhjNex+krWBwZqR5g8o= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 696C63858D21 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Dz12dbgFZJ1h9lVjGIpolz49j5/RzISVrrMQEYeOyfSviWrLkNBJ03a3u1HiW9TLroO5Casl1nrIv+JOyfzZ57EUCqt6YJvdMPB1boYmDvV1ot13h7G8kHUFVv7aXWM6PG5ufZzurXYNFLHM4DLF/gk0hsE7N2GLnY3IpByWVy8gCZLVkf3bi9ZcGMpbsjJchV/6NkocxZ1IahxkT0W5/B4oZHyath0mU09bp41zhkqPIw3YaRtNbUs2EfWz0xfJpiK74XEr++CvUDJ2Dg9Ya1zG1mYuGh8yCQN4PDyTAS6bW+n8nIy7bkE9UM3P8tHr+ToNAmHVVaJkh8xAcDYlCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=auQOknieEknrNuPX+5kyTy6W8GHtdGQI5UO/6Sh2yWg=; b=ZbYzf4nbBQNhbWqxC3I0XovtWxDD7qTgSwcrzRBFw3U9YdZNzVe9FKrapk5M77DjLWK/dVHg1w9yUNMXTNp4tuC5aJ46ODVsRn6qN5TYohxMJ2mXuaS73XpdpK6FBiQi2KoViOedMBNoRF3gZ1dCfoG4Irw7hmquWhUtz7rP3VHgyaE0wSfzG2IA9ixuDieEpQYd/0ZP/koXZ36+eeKqjbLQEjiCuLTrkYodWK8Al+Ksb42Jtsq7lZBbFsjLDXUE8vUcWuIUhL6IsrG7sa0BAMMBQR7SMGnJydEa4eR/Lz8Iupslk2VrfE/Doac6e/Nn9kW+MN0Dmozt/u66c3WbVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=xmos.com; dmarc=pass action=none header.from=xmos.com; dkim=pass header.d=xmos.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xmos1.onmicrosoft.com; s=selector2-xmos1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=auQOknieEknrNuPX+5kyTy6W8GHtdGQI5UO/6Sh2yWg=; b=SH6Iaz9nEuRVU8nalHHAFquC1nBh7KqIzEExPG5Qdjwre7kr71ZL3+0EBMFiMuDleXpAmrkAjjQ7M6FF4rIB81bqVWK2xF3f+mRVg4NDcavlOkxosbUEaAVKTwEvC5SKW9lIHY3qz16Hf73wNsDds1/Xtmw2OFKi7CYY6AiG4s4= Received: from AS8PR09MB5303.eurprd09.prod.outlook.com (2603:10a6:20b:374::5) by DB9PR09MB8063.eurprd09.prod.outlook.com (2603:10a6:10:5c8::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9094.22; Fri, 12 Sep 2025 17:17:07 +0000 Received: from AS8PR09MB5303.eurprd09.prod.outlook.com ([fe80::1ea1:e219:22:9bd3]) by AS8PR09MB5303.eurprd09.prod.outlook.com ([fe80::1ea1:e219:22:9bd3%4]) with mapi id 15.20.9094.021; Fri, 12 Sep 2025 17:17:07 +0000 From: Ciaran Woodward To: Tom Tromey CC: "gdb-patches@sourceware.org" Subject: RE: [PATCH 1/1] gdb/tui: Fix build for older ncurses Thread-Topic: [PATCH 1/1] gdb/tui: Fix build for older ncurses Thread-Index: AQHcI0omuY76yJUbo0Gnx9KsphB0srSPpm11gAAk+4A= Date: Fri, 12 Sep 2025 17:17:07 +0000 Message-ID: References: <20250911183021.17844-1-ciaranwoodward@xmos.com> <878qijogpi.fsf@tromey.com> In-Reply-To: <878qijogpi.fsf@tromey.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=xmos.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: AS8PR09MB5303:EE_|DB9PR09MB8063:EE_ x-ms-office365-filtering-correlation-id: 847932b9-d653-4fe7-8522-08ddf22033c7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|1800799024|366016|376014|38070700021; x-microsoft-antispam-message-info: =?us-ascii?Q?poIeyczQ0sB6Nwm9wRkr3g29SkYe+I8TGW3SGwfAzIfICirkTE/ti4oOkfS9?= =?us-ascii?Q?qVq0h0VpkFQnBkYNXQsiZx/AEUG0QG1o5JHJmDDKmInVa+g0lgZLo9BLHNi8?= =?us-ascii?Q?kO4k/TBtBLRMPzFqxJ7gL0VJnArVfs/WEC0TG0jMFUsh45IFP0uWEIj4L8WJ?= =?us-ascii?Q?ULEip6XRakHwx5R0JWS1J0KqJkpq4K0JHvNEXNMoCzRW8kL1i0+svJtcrqY2?= =?us-ascii?Q?ys3bb8cR9LfzU4u5BKxAlcigbbTAcGNqrNjdHbjE2NAbvFmROlYeuJ0JYYjI?= =?us-ascii?Q?uYBpm1nRq7T0geDYbuBxf7B0QPV6uZSrx29+jLOZP32ei4a6Fa7gKtRkwgRt?= =?us-ascii?Q?8QfUvTORYNcO77/RvBhqZChfvmkuRUV3aDsQfQR5BWb6h8ifTKunlGh1KItX?= =?us-ascii?Q?JBnNFnwFkFI0lM7vFu/yJ8DiJVrF9v6ul3LdU1GzMUSV9T9Im3P8vjcdUVm+?= =?us-ascii?Q?Ol7hTHP88mZ6SHAQJkCdO1iFXY/1zQLcCisAwbQmIdqFoLSw5ZZROJdOZ5hl?= =?us-ascii?Q?eEcMpwgYGgBLckPdkUXhUmAF20mTGOWa0k8e1OdxUbl6/dxooTgHYPjdKYoz?= =?us-ascii?Q?aAFh0jOt69dPXjkHsfKNhvBTc2cOGbXVBC+P8YtsUh1Msi/dPsEiOTre5G/G?= =?us-ascii?Q?ufEsX2CwIzSSmDKg4lCrYxskTdRGI136z3vCDjPNf1NKL9B3rCU05kNd55Um?= =?us-ascii?Q?eIA+hyT0AuQA9BeBYeditoJ8WOAdEKAFV7V0nTMcPDf7pW6lmTDAWhPR/wg6?= =?us-ascii?Q?G/NbpSFMCgqPfLqHqtdfCTHiGH1qwytoBe0810PbbEXYl8cNM5pmikG6217j?= =?us-ascii?Q?X85XDM5p2dRucowLH6Ke9iGoPIKfKf6vj4JlO6fpoFiqr9ZzbEGrn2HP0NzD?= =?us-ascii?Q?plSK5TrxP2AYzdi43Y/ltcQ4ZeAkFuUGhP+FHcrADWx7QZoMpvdTcNqiAdOA?= =?us-ascii?Q?/6mIWz21YJnjq2jWne0B4vvyfmdnNff1UGCxG2E+mglM9UJWRRHWV8sJc868?= =?us-ascii?Q?5jsn4wQXk4wMzctb0BiWigc2N8K298lCT70Y6PW+6GieVt9fePKIVYUJ8CyS?= =?us-ascii?Q?Cb7vXL1H8mjDZ1IyB8yrB/ud3JqEut5xMRdm5pzLPxNXeoxEKEiBDkYAVtgi?= =?us-ascii?Q?cx/NO6jBMfOJzOpXDrGRoZOy0nRnnQFW5szJZgBZBFJvgggvufMcLdfE52Cu?= =?us-ascii?Q?6l4nUTUSDfx+OSyFY3QV9/nWwX87/HIu32egpEOn1aDJDCXgkJP7jpldwJSn?= =?us-ascii?Q?Q4XiRvHLfSuc0zMvuopy/46CSc1XmTfSL18A8XyDojDHufh5LhZ98ukRmt3E?= =?us-ascii?Q?clw6idpOI90voIBZLQXBkC2cNpVGkVzBDMYOBEwMMliMSqWXmHGQFZqozMtF?= =?us-ascii?Q?o/LIR2WrnJHuKCxIR4azd8PB11e3Il3uFShPlLdAmXF9VX2kjP6CvR4FP5PU?= =?us-ascii?Q?fpNF79om3R1kklGTFmPzcSvdLBcUpE4oO4Z4aNlq2w1Z+teUeHCLiQ=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR09MB5303.eurprd09.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014)(38070700021); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ZmwqbO+qR6JRuW1dtz6FUoT6ssPKVrNUSvSgoISpQ0daulhTbB+uuDCl2XHs?= =?us-ascii?Q?UYwbqFS7c7kwKpLESvJ9ENxYh/atiwQHeO1AIOKli9MtkhQ1cE52MktkyBhw?= =?us-ascii?Q?Kp4sxPT2xWD0nUJR5bEGIOH5l5jvfXbeQJ2REiijgEUa71QeXqaAARV9QOdD?= =?us-ascii?Q?Z1j9276U+N4E1tLSHGqNWtt4HjGdgYFMbmolV3K3nBdoRI+fFFhvikGdlstA?= =?us-ascii?Q?6bTEwEW6V5Gcdrde3c5m3mmkKpnSQTDOlJ/84p1q7/9FTD1s+XiumqGG2VrG?= =?us-ascii?Q?6AQqTAyKaTt7Od94NOo0s+jg16Iua5a34btIUBj+f2XebIh8509zyC2eyiJz?= =?us-ascii?Q?Rv8JN42NJVyoHblURdl+1MAEjRpnvp3OCA7BgXwgkZ8rNab5/ZykzRuyBm8b?= =?us-ascii?Q?sfDCY/H3Pj/Bdtv//6Iuyn0CAWEU8WyrrIu9BP+MlqjTS89QX37YLKtN9b0H?= =?us-ascii?Q?Lzqz01Jd38UYBK0v58ulHW68gaA53jTN3SoKThmeio0sjlZaHxS6Vytjv6jc?= =?us-ascii?Q?P9VAWW2jZ/CVWojc1ACwXiNvJGXLbs+YUL+yazOv7xBPiCZrzTKWe3iSkezE?= =?us-ascii?Q?Y5Aq1LiPuuazxHZRytViicQF9X/gHe1vrei9B5BQpXIo7kRsJe4CqlJKDxuC?= =?us-ascii?Q?cikQZQ2aOWDlAru5qIcHymBPUhHH7/Of7cHS3dWJ2NXYo117CV/lrFxAJRJp?= =?us-ascii?Q?FXTv352MonCIAFds/XSapRT4MKTAFaMcnCOj3cDBoomG7X316pUVKagazpIF?= =?us-ascii?Q?6+Y7V8bqy1NoNk5ntc80kBkWiS0C1ybDIV9sRLw3yZwbracupk4vb6iuAAQq?= =?us-ascii?Q?DoauASg+2relbx94dPkQO/T/PrybiymY+DSglN0WcekaGQjIN0OGSBQdpMxh?= =?us-ascii?Q?qxD2YnD4LnKTlnezNEibUrJ57FiTOqvcu1b3aqpHlnUWgMWWOSgLZD1kdARD?= =?us-ascii?Q?UwYaHdm6kMBusNqFca8kK3d2RX1LohMFRaoFWaBJmRYwy/cNQSCNRlW59459?= =?us-ascii?Q?/Qks4ApW3WD6QFpLWBcRDL7vV7GoyQS8/q7ciPqhJrF9WvQ8bB8InlTz7TTO?= =?us-ascii?Q?WCVwQ2GryhjcXr8mHZLDjBVKZmEpQygAXHPddfFG0rlfZY9HlAJIAbdMhN2c?= =?us-ascii?Q?yu9d5HJmoyM4+37PsISmIYookS1Bzm2e2PZksWXo5kcATK96HxI4/DvQbn4P?= =?us-ascii?Q?3WDkB9tH1S+CEajGigalukOWmoWvCWC8ps9Azhu0yaVNQ7YqtTwBNnfWU8Hm?= =?us-ascii?Q?LuCdp6ddtDyPwXbzejnfyEJLdthLgZwWIgUBwERhsCkpKXBvmfVgDS6IV8Zh?= =?us-ascii?Q?qt+n4uAAFkN7q4gsz2hUnojzEVNk/y+s2oJBHY48RPZgLav91/uoVk1ENefE?= =?us-ascii?Q?95CT6FW7Yndbrhh3SyYYVRGI373JnRzRT7UhR4K0CeGdnFyPZw53bGWsm7t7?= =?us-ascii?Q?eUNd4XHO3LqDkAjsKXzMuPHwMw5Wd4HKT/xcOWm80DWJAyvC0cIyEA9HzYAB?= =?us-ascii?Q?Cc4rIIcaHvUEGq3tiCjg0Npp08kAWG10k6Mkt79tI6CA9bi8RF/IDdn9i8xc?= =?us-ascii?Q?nSN8XLzv4onxuk2t0Y6mtwbuVc3Ry9AVQztf2xbg?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: xmos.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AS8PR09MB5303.eurprd09.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 847932b9-d653-4fe7-8522-08ddf22033c7 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Sep 2025 17:17:07.7896 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 975ecfb1-4080-42d2-a01d-4a4d0707a539 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lifSMVOb2W02a9cBb3A5aK/Kg6endn0B36TpTk9Woz8dzJ5Us6omd0HhLwSv4Oz4W9OftIb2hUuEOMYclSToiQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR09MB8063 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org > Would you mind adding a comment here explaining the need for the cast > and also for which version of curses it was found to be needed? > I think that may help future developers. >=20 > Anyway ok with this change. > Approved-By: Tom Tromey Thanks - added the comment & pushed.