Re: [PATCH] Fix test failures when TUI is not enabled

[Bernd Edlinger <bernd.edlinger@hotmail.de>]

On 8/9/24 13:17, Tom de Vries wrote:
> 
> That sounds like you ran into that PR then.
> 
>>> Anyway, adding require allow_tui_tests in those two test-cases looks wrong.
>>>
>>
>> Okay, but what is going on then?
>>
> 
> We can get the same effect using "TERM=dumb gdb".
> 
> It forces readline's horizontal-scroll-mode to activate (unfortunately, without affecting the value of the corresponding variable that we can read with bind -v).
> 
>>> In the case of gdb.tui/wrap-line.exp, there is already a test that bails
>>> out if TUI is unsupported, but still allows testing of things that should work regardless.
>>>
>>> In the case of gdb.base/wrap-line.exp, it's a test-case I added specifically to test the behaviour of prompt wrapping in the CLI, not in TUI, so requiring allow_tui_tests there is non-sensical.
>>>
>>
>> Well is there a better way to detect the issue without going into this long timeout,
>> or can it be fixed somehow?
>>
> 
> We could accept the string produced by horizontal-scroll-mode and produce an unsupported and bail out.
> 


Hmm...,


--- a/gdb/testsuite/gdb.base/wrap-line.exp
+++ b/gdb/testsuite/gdb.base/wrap-line.exp
@@ -115,6 +115,9 @@ proc test_wrap { width_auto_detected } {
        -re $re {
            pass $gdb_test_name
        }
+       -re "\r<.*" {
+           unsupported $gdb_test_name
+       }
     }
 
     # Generate a prompt.


This works as expected, but I see no way how to do the same
in gdb.tui/wrap-line.exp because the 

... and other than that there is also
FAIL: gdb.base/wrap-line.exp: term=xterm: width-hard-coded: $gdb_width == $readline_width
FAIL: gdb.base/wrap-line.exp: term=xterm: width-auto-detected: $gdb_width == $readline_width

(gdb) PASS: gdb.base/wrap-line.exp: term=xterm: width-hard-coded: set width 80
show editing^M
Editing of command lines as they are typed is on.^M
(gdb) maint info screen^M
Number of characters gdb thinks are in a line is 80.^M
Number of characters readline reports are in a line is 79.^M
Number of characters environment thinks are in a line is 80 (COLUMNS).^M
Number of lines gdb thinks are in a page is 4294967295 (unlimited).^M
Number of lines readline reports are in a page is 32767 (unlimited).^M
Number of lines environment thinks are in a page is 25 (LINES).^M
(gdb) PASS: gdb.base/wrap-line.exp: term=xterm: width-hard-coded: maint info screen
FAIL: gdb.base/wrap-line.exp: term=xterm: width-hard-coded: $gdb_width == $readline_width

I wonder whether that can be used to detect this situation,
when bind -v is not able to it?


Thanks
Bernd.