From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id CfCVHp2VuWZT+gMAWB0awg (envelope-from ) for ; Mon, 12 Aug 2024 00:54:53 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=HOTMAIL.DE header.i=@HOTMAIL.DE header.a=rsa-sha256 header.s=selector1 header.b=JET8MRqJ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 640AA1E0D0; Mon, 12 Aug 2024 00:54:53 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2AEE81E0AC for ; Mon, 12 Aug 2024 00:54:50 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 91B083858C39 for ; Mon, 12 Aug 2024 04:54:49 +0000 (GMT) Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazolkn190110001.outbound.protection.outlook.com [IPv6:2a01:111:f403:d201::1]) by sourceware.org (Postfix) with ESMTPS id 908123858D20 for ; Mon, 12 Aug 2024 04:54:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 908123858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=hotmail.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=hotmail.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 908123858D20 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:d201::1 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1723438469; cv=pass; b=m0d2exOkQ6/6g1u43POTDVyt2s6et5i8DRxqv3OTfL73mHnRpdNYPmsDI3XL//S/ssP73idJklROBH8iTP8XB7apvoUBtSS9wCuf5Xvjz6PJv8VsMKb9t2JLsksSOZgbnkmhyXGIGAUc6W+vYkKpQcifmaLP5u7ZADftSdi3HH8= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1723438469; c=relaxed/simple; bh=EkdSE5pJ8dLOYj9wKzkjp6hKwRbzZYuEo78JmSSN6sk=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=PtFi3PCACEnkwiyBl2zfpSup+jxguTqJfSx5x4qRfay+0Wi3MiP1G0DNTL5fOPL3twY3wUo5bg9CTlNiO3SxO2p4/ft4jt2sm0h1AI5cWyXZ2nDQHoaO7F50QNN2I49bK2sfXxYS2pFVrbsbRSRhIQqJzbdYBUAG+pAB/9iDvEI= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KBwbySD9ba4dwGR0ruo9qe0Hj9HNFBqKqaUomMaPmoEp5wYBFOyR1iHjZdY+RpYmXw+lhA3hl6eRxWMjJ5rbHT0wtGg1FO1GRC49er8EERw5HVxVLiLwxA2JwjQagJfhQtWFVDcKuTcQJvwUSNpUN1XE2T0hyriurZYo36vG4NxYB1lI6IA3I3CFpj1i5bnIfkmYK1wnX92176cihvF0YWoOEulkzQn+z+LSc1mRW0r6jXHig0CMDCoOZ/u1YO3jyAn+rkGpLNt1vmR0ob4M7YsL1bDaq3GU71RUIZpc1Y/P6YacDT+t6PM2yAXxLNC5mfpyXVCK4VRRLO+yumYSQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RgrjqPnD0LHMOtpAcs4mD5viB/fcRb1HzmQ7KY/1SKU=; b=caVfQbUwLxCMu8sAazAlCVhcyFJXEtd7TKLHAwbFAoCHAt84VN4VhFuti1tjsX64NXku+bxr5Mbktl0/BXxhjS7vcoujtcqlqFvWstBSS6OMy0GUik6CzSiVhNfO+Apw2NqhfUSO7M2Xuzb8kD8NOusNUC9BeZp6k72F04k23B2YEGw/+8Z3ovu1jwIxNJ5PmRf6mCtEhaPC4BLgVc2q4PCDsEH8ZKIAd9D1A9muoSJKRuOJXLivfXCyCsmb+I0WkhoWMEu2OSOB2VdeX5zCk147QFBLAhE94+cEBpa5fhdhxbkllMBS9dhEdVGUFOJYsKCzDsKVO0nwUCTFr8Vwmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=HOTMAIL.DE; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RgrjqPnD0LHMOtpAcs4mD5viB/fcRb1HzmQ7KY/1SKU=; b=JET8MRqJ5BVzRAp4CPmXxiqIEW5LXcxHeEmxYRF0ExvLExopYH5vQW4IyRIJtlA0aLf1CeKx7lTOflgW9yHQVzPkZgqbGaAfcybp7BVfQTE1nZsHY8iinUuNxIz65p5zvnryJtL7+wiK07W49ajkvyCEcIphlmZf4t+WARhywosKSelsDWLSIzrgwKUzODmdEKXEmAVy6sXoKO+khrorhybPRgyU31zMaYPaznC+cR3Qe05zD/EASow494Rw3/F6Qvzfg30vOvuoV7dAuNWXgNc05zqOd/nx9u+bsr3M5bfm/FT3j1g4lCOEXq5RFjrSJMFBcB8UMe3H9ZOHRiGl3w== Received: from AS1PR01MB9465.eurprd01.prod.exchangelabs.com (2603:10a6:20b:4d3::20) by AS8PR01MB7896.eurprd01.prod.exchangelabs.com (2603:10a6:20b:35b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.20; Mon, 12 Aug 2024 04:54:22 +0000 Received: from AS1PR01MB9465.eurprd01.prod.exchangelabs.com ([fe80::ea10:4661:33e:18c]) by AS1PR01MB9465.eurprd01.prod.exchangelabs.com ([fe80::ea10:4661:33e:18c%7]) with mapi id 15.20.7849.013; Mon, 12 Aug 2024 04:54:22 +0000 Message-ID: Date: Mon, 12 Aug 2024 06:54:18 +0200 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Fix test failures when TUI is not enabled To: Tom de Vries , "gdb-patches@sourceware.org" References: <1cdc325d-4692-425d-a2cb-52197054c015@suse.de> <0b383d4f-9d37-403a-9fc5-cae7e27b1673@suse.de> Content-Language: en-US From: Bernd Edlinger In-Reply-To: <0b383d4f-9d37-403a-9fc5-cae7e27b1673@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TMN: [iVzan8YRpF0Zz+iE1B7Qk7g3RA9X0tpSK/z8Drs+VgIlRcPir3VKJO3/wQoeD+RK] X-ClientProxiedBy: FR0P281CA0137.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::13) To AS1PR01MB9465.eurprd01.prod.exchangelabs.com (2603:10a6:20b:4d3::20) X-Microsoft-Original-Message-ID: <4ef542fc-18fe-4a75-9ed0-2f2bd09ec190@hotmail.de> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS1PR01MB9465:EE_|AS8PR01MB7896:EE_ X-MS-Office365-Filtering-Correlation-Id: 5e6a1017-4e37-4e5e-81cc-08dcba8ad4df X-Microsoft-Antispam: BCL:0; ARA:14566002|461199028|19110799003|15080799003|8060799006|5072599009|3412199025|440099028|4302099013|1602099012; X-Microsoft-Antispam-Message-Info: UTbb7CpssOTY88KLE61WwZjpmBH8kZgN4gnVsoGoSukr6punAL6kP0FVBInfK8j1TRoRxKrxLTHvG3TzFxl/S3QYEvQdou4N1NGGAFB36el1p5QGJ4lQb1NqdJnqGwaA933fuaBakxz/iuP54l4ee5U3/4EFf5/lYOIqtar9Neq4kBCSzKcAzHma901AC2rmvGmlx8PGayAVEg96BNrLcJPWHkk9pSSHJxfocnwwbyUWOxzY/S1DZ+kzDyNTUv/DjrMDpear9vKKC7ZHuhr5aUj1qGXNYT111b03ufX32tKWaTyiOH6haI9/RzQrRI9VT3jXk+jQc3Okc0F3EA5hhn2G6l5j/JTJ6waUbgx84Iprq6JZH6fJPbJW9RtRKShs9J81yG+fmSjk7f3AlAqJpCGAkNxh935cdaUH44t6L22rZhgXu3ahfEDwNeC7zpHlWrEd7Hnx/sI/nsiCRXTfPLanZZbs4+yrkfpGYBq6+mUdUenetsa5i/Y71Ma03YVC0yfTVDWWbEtl4lM2OKGtR39A0rZA8uTju/nMV9LkbzrIHtRlFNCYeBmDaAgx6niL1BswkYRcF/FyyYKiMiog/iJ1PkCz6wcv0OdJXtt8HkI0nE+Bpcw6Rxj9Y+JQ7zflQdCMh9YGK8ij4eJFNnqAVwYXS/HQphYVS1PFVWO0b0sTlFDiepdzgt+kdXk38CpPuum0ZEXyQlHZCXqM5cNasDrrQPweAEVVZSBMgzvG0+X8AiDbyPPU88TXXLMs19q2GLolaG7M8+qGlm4YWWx4UAPbcWuwph8ikJZNB8SnvZoJQggW2oiymDat5DCQbE/C X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cjFkZlp0Q1VGaWVVdHRKRy95N2pLMURsMzlHYjA4cDZ0STk2SzdralAwQUVn?= =?utf-8?B?QzRrSHFMRzB6bUMyanVTNUUrUXNTaEVyZmI4UFlqZm9kWkNZMzZDL1BCSXRZ?= =?utf-8?B?cVBXNFpqdmZIWFA2Ti80eWNTN3B4cE5NYUE2Wkw4Qm0ybWNHckJmWXcrZTVm?= =?utf-8?B?bXAyVVlLMlJsbm42eEwva3RvYW81dzd0eURRa1IvdSt4S0hORlhSL1UvMEEz?= =?utf-8?B?WGtlSVBwWDhLVkpNaDI1V1pEaDB2VEIvb2J4SzNNOHZHNE52azhKb3ozdW5r?= =?utf-8?B?QVRlOWtLYjcyR1dJOTJxRCsvU3lMRHh3QUhHZDRhenBRYzVsWjZXdFV0Q3lB?= =?utf-8?B?M3dqRExSd0p6ZWZkOHVtZXYvSFRkeFFHdmtLamRsc2RtaW53ZitvdnZIZHpy?= =?utf-8?B?cTlwcjdQN1NLUk8wTXJTMytnN3grd3g0S2FKdTZNRTZJRHlSeEdsMExZVnFu?= =?utf-8?B?eVRaZTlqTk1yZnRSVld1RllJTGxqbmxlN1JteXo5b3VXMHdHNHNsN2wrbWs3?= =?utf-8?B?SUZHTU9kYXZITmxVSHpTQzgvTFNDM0pueXZXWGxPdmRoYmRmWm1BQzh2YXEw?= =?utf-8?B?aEw5ZkJTWkcwNUdueG1zT0RWU2hQTFpZZXU2dVJKY2prN09GMG16TEZ1TnBw?= =?utf-8?B?TjlwNlY4dGtFNkZlWTlaTEIvU1FVV0I1aXpFVU0wMHh6bzl0RnVlNW1IY2Yx?= =?utf-8?B?ditXK0dkTVBJbkNzcWd5UXRYQnlCbU01RDJpQ3FDbTk4WnJNQjMwZGhCS1lq?= =?utf-8?B?Mk9MWWRyS3VwTmxNNS8xQm1xQXl0dHZYd1h6dnpad0ZqcGVES0xSWXJyeDJB?= =?utf-8?B?TnhWNldZcFFIT3F0Ris1TDFaWWxXQkF2dWthcjA2T0NiTitXd01CK3J4eVFl?= =?utf-8?B?S00wQ0dWejk4Zk5QTnoyQkkyY1QvNGh0QjRqVnd0UzFqT1FXZ0plMTNvVm0r?= =?utf-8?B?NG1WRFJBMnlnQWVFbktUZkhXUXdyUGpIVDhNNnFtRUg5WXVLNzJ0L1IrUGcz?= =?utf-8?B?NjNubllSWHRhVjBHaHoyV2lEMDROK0grMjlxRW9PbmxlSzdOcVNLcUNOa09t?= =?utf-8?B?STRuWElqUFFmYkZCWEZQSE1wM3ZKK0J4YzBneGFXSDZWUE5mOTI2MUJHdUpk?= =?utf-8?B?VUdhQktWaEl2dy9FelVVdjVNc1Z2L0VFWHFsdzR0cnpvWDg0WEtZZGNkMmJm?= =?utf-8?B?L1FIZzBtbVo5Y2tEWG1ZRVhqNkVqaFdBMVNqN0hsTTR3VmV3bTZTaVhiVkNJ?= =?utf-8?B?YVdBNzhJSmExQW5BSTlpN2dLb25rRy9MSmVsTVRoVnRrTXN4b0NabU9nd0hI?= =?utf-8?B?ZzlsczgrZHhKVzM4MmhZR1FYd1MyUTFIUGNuSmZoQlZoMXlIUEQvMkoxbXJE?= =?utf-8?B?R3JNZmd1cG4xMHJkTml6KzFHUHg4YlpldlRjSmpHSk93b1dnbGYyNFJiN3FU?= =?utf-8?B?cHJmRlo0aitVR1cyMXI5UjBhNkNQc2h4ejVQRkxpUkUvcDFZUUVCanZDSldP?= =?utf-8?B?ZzNucWp0elpXL2xXdmlxcjhkR2Y3eXVUU1VpbVRUcUxQUzRldjRHWHMrdVdB?= =?utf-8?B?bFJiR3pQWjJ2dStpY1YvaHlpM1NEb2tPYWlXNmN6aUZERDg4cE52bDhSRThL?= =?utf-8?B?QWlRNkQ3ZmRtL1k2a0dIMURSYTNDVlhhb0RZNEd2N3AzeExCd25FeUt4bEVi?= =?utf-8?B?U1NHcFRvaG9pdkRxUDViUXRiNGRDcEhZMGIwTjZ3eVkyVllwZ1dqUmF2WGVF?= =?utf-8?Q?QU21UMDalg8wmMSKdbnSrribi5UPd200QSz6+O0?= X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-ba98d.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 5e6a1017-4e37-4e5e-81cc-08dcba8ad4df X-MS-Exchange-CrossTenant-AuthSource: AS1PR01MB9465.eurprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2024 04:54:22.1719 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR01MB7896 X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, KAM_SHORT, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/9/24 13:17, Tom de Vries wrote: > > That sounds like you ran into that PR then. > >>> Anyway, adding require allow_tui_tests in those two test-cases looks wrong. >>> >> >> Okay, but what is going on then? >> > > We can get the same effect using "TERM=dumb gdb". > > It forces readline's horizontal-scroll-mode to activate (unfortunately, without affecting the value of the corresponding variable that we can read with bind -v). > >>> In the case of gdb.tui/wrap-line.exp, there is already a test that bails >>> out if TUI is unsupported, but still allows testing of things that should work regardless. >>> >>> In the case of gdb.base/wrap-line.exp, it's a test-case I added specifically to test the behaviour of prompt wrapping in the CLI, not in TUI, so requiring allow_tui_tests there is non-sensical. >>> >> >> Well is there a better way to detect the issue without going into this long timeout, >> or can it be fixed somehow? >> > > We could accept the string produced by horizontal-scroll-mode and produce an unsupported and bail out. > Hmm..., --- a/gdb/testsuite/gdb.base/wrap-line.exp +++ b/gdb/testsuite/gdb.base/wrap-line.exp @@ -115,6 +115,9 @@ proc test_wrap { width_auto_detected } { -re $re { pass $gdb_test_name } + -re "\r<.*" { + unsupported $gdb_test_name + } } # Generate a prompt. This works as expected, but I see no way how to do the same in gdb.tui/wrap-line.exp because the ... and other than that there is also FAIL: gdb.base/wrap-line.exp: term=xterm: width-hard-coded: $gdb_width == $readline_width FAIL: gdb.base/wrap-line.exp: term=xterm: width-auto-detected: $gdb_width == $readline_width (gdb) PASS: gdb.base/wrap-line.exp: term=xterm: width-hard-coded: set width 80 show editing^M Editing of command lines as they are typed is on.^M (gdb) maint info screen^M Number of characters gdb thinks are in a line is 80.^M Number of characters readline reports are in a line is 79.^M Number of characters environment thinks are in a line is 80 (COLUMNS).^M Number of lines gdb thinks are in a page is 4294967295 (unlimited).^M Number of lines readline reports are in a page is 32767 (unlimited).^M Number of lines environment thinks are in a page is 25 (LINES).^M (gdb) PASS: gdb.base/wrap-line.exp: term=xterm: width-hard-coded: maint info screen FAIL: gdb.base/wrap-line.exp: term=xterm: width-hard-coded: $gdb_width == $readline_width I wonder whether that can be used to detect this situation, when bind -v is not able to it? Thanks Bernd.