Re: [PATCH] Fix test failures when TUI is not enabled

[Tom de Vries <tdevries@suse.de>]

On 8/9/24 10:47, Bernd Edlinger wrote:
> This adds some missing require allow_tui_tests.
> 
> When tui is not enabled those test cases do typically
> fail, but most of them only after a long time-out:
> 
> FAIL: gdb.base/new-ui.exp: do_test_invalid_args: new-ui with tui
> FAIL: gdb.base/wrap-line.exp: term=ansi: width-hard-coded: wrap (timeout)
> FAIL: gdb.base/wrap-line.exp: term=ansi: width-auto-detected: wrap (timeout)
> FAIL: gdb.base/wrap-line.exp: term=xterm: width-hard-coded: $gdb_width == $readline_width
> FAIL: gdb.base/wrap-line.exp: term=xterm: width-hard-coded: wrap (timeout)
> FAIL: gdb.base/wrap-line.exp: term=xterm: width-auto-detected: $gdb_width == $readline_width
> FAIL: gdb.base/wrap-line.exp: term=xterm: width-auto-detected: wrap (timeout)
> FAIL: gdb.tui/wrap-line.exp: width-hard-coded: cli: wrap
> FAIL: gdb.tui/wrap-line.exp: width-hard-coded: cli: prompt after wrap
> FAIL: gdb.tui/wrap-line.exp: width-auto-detected: cli: wrap
> FAIL: gdb.tui/wrap-line.exp: width-auto-detected: cli: prompt after wrap
> ---

Hi,

I disabled tui support using --disable-tui, and can't reproduce the 
wrap-line fails you see.

Is it possible that you're running into "[gdb/testsuite, stub-termcap] 
FAIL: gdb.base/wrap-line.exp: term=ansi: width-hard-coded: wrap 
(timeout)" @ https://sourceware.org/bugzilla/show_bug.cgi?id=31201 ?

Anyway, adding require allow_tui_tests in those two test-cases looks wrong.

In the case of gdb.tui/wrap-line.exp, there is already a test that bails
out if TUI is unsupported, but still allows testing of things that 
should work regardless.

In the case of gdb.base/wrap-line.exp, it's a test-case I added 
specifically to test the behaviour of prompt wrapping in the CLI, not in 
TUI, so requiring allow_tui_tests there is non-sensical.

The change in gdb.base/new-ui.exp LGTM.  You could submit a v2 with just 
that change.

Thanks,
- Tom

>   gdb/testsuite/gdb.base/new-ui.exp    | 8 +++++---
>   gdb/testsuite/gdb.base/wrap-line.exp | 1 +
>   gdb/testsuite/gdb.tui/wrap-line.exp  | 1 +
>   3 files changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/gdb/testsuite/gdb.base/new-ui.exp b/gdb/testsuite/gdb.base/new-ui.exp
> index 2dfcbf7e108..a56d213e527 100644
> --- a/gdb/testsuite/gdb.base/new-ui.exp
> +++ b/gdb/testsuite/gdb.base/new-ui.exp
> @@ -184,9 +184,11 @@ proc_with_prefix do_test_invalid_args {} {
>   	     "new-ui with bad interpreter name"
>   
>       # Test that the TUI cannot be used for a new UI.
> -    gdb_test "new-ui tui $extra_tty_name" \
> -	"interpreter 'tui' cannot be used with a new UI" \
> -	"new-ui with tui"
> +    if [allow_tui_tests] {
> +	gdb_test "new-ui tui $extra_tty_name" \
> +	    "interpreter 'tui' cannot be used with a new UI" \
> +	    "new-ui with tui"
> +    }
>   
>       # Test that we can continue working normally.
>       if ![runto_main] {
> diff --git a/gdb/testsuite/gdb.base/wrap-line.exp b/gdb/testsuite/gdb.base/wrap-line.exp
> index b0931a3bbb8..1a1b47410ee 100644
> --- a/gdb/testsuite/gdb.base/wrap-line.exp
> +++ b/gdb/testsuite/gdb.base/wrap-line.exp
> @@ -18,6 +18,7 @@
>   # We set TERM on build, but we need to set it on host.  That only works if
>   # build == host.
>   require {!is_remote host}
> +require allow_tui_tests
>   
>   # Test both ansi (no auto-wrap) and xterm (auto-wrap).
>   set terms {ansi xterm}
> diff --git a/gdb/testsuite/gdb.tui/wrap-line.exp b/gdb/testsuite/gdb.tui/wrap-line.exp
> index 9cddcf14995..48a04ebc330 100644
> --- a/gdb/testsuite/gdb.tui/wrap-line.exp
> +++ b/gdb/testsuite/gdb.tui/wrap-line.exp
> @@ -17,6 +17,7 @@
>   
>   # Required for tuiterm.
>   require {!is_remote host}
> +require allow_tui_tests
>   
>   tuiterm_env
>