Re: [PATCH] Fix test failures when TUI is not enabled

[Tom de Vries <tdevries@suse.de>]

On 8/9/24 11:48, Bernd Edlinger wrote:
> On 8/9/24 11:28, Tom de Vries wrote:
>> On 8/9/24 10:47, Bernd Edlinger wrote:
>>> This adds some missing require allow_tui_tests.
>>>
>>> When tui is not enabled those test cases do typically
>>> fail, but most of them only after a long time-out:
>>>
>>> FAIL: gdb.base/new-ui.exp: do_test_invalid_args: new-ui with tui
>>> FAIL: gdb.base/wrap-line.exp: term=ansi: width-hard-coded: wrap (timeout)
>>> FAIL: gdb.base/wrap-line.exp: term=ansi: width-auto-detected: wrap (timeout)
>>> FAIL: gdb.base/wrap-line.exp: term=xterm: width-hard-coded: $gdb_width == $readline_width
>>> FAIL: gdb.base/wrap-line.exp: term=xterm: width-hard-coded: wrap (timeout)
>>> FAIL: gdb.base/wrap-line.exp: term=xterm: width-auto-detected: $gdb_width == $readline_width
>>> FAIL: gdb.base/wrap-line.exp: term=xterm: width-auto-detected: wrap (timeout)
>>> FAIL: gdb.tui/wrap-line.exp: width-hard-coded: cli: wrap
>>> FAIL: gdb.tui/wrap-line.exp: width-hard-coded: cli: prompt after wrap
>>> FAIL: gdb.tui/wrap-line.exp: width-auto-detected: cli: wrap
>>> FAIL: gdb.tui/wrap-line.exp: width-auto-detected: cli: prompt after wrap
>>> ---
>>
>> Hi,
>>
>> I disabled tui support using --disable-tui, and can't reproduce the wrap-line fails you see.
>>
>> Is it possible that you're running into "[gdb/testsuite, stub-termcap] FAIL: gdb.base/wrap-line.exp: term=ansi: width-hard-coded: wrap (timeout)" @ https://sourceware.org/bugzilla/show_bug.cgi?id=31201 ?
>>
> 
> Yes, that could be the case.
> 
> I did not explicitly opt-out tui, I just did never care to install
> e.g. libcurses etc. and the configure did the rest.

That sounds like you ran into that PR then.

>> Anyway, adding require allow_tui_tests in those two test-cases looks wrong.
>>
> 
> Okay, but what is going on then?
> 

We can get the same effect using "TERM=dumb gdb".

It forces readline's horizontal-scroll-mode to activate (unfortunately, 
without affecting the value of the corresponding variable that we can 
read with bind -v).

>> In the case of gdb.tui/wrap-line.exp, there is already a test that bails
>> out if TUI is unsupported, but still allows testing of things that should work regardless.
>>
>> In the case of gdb.base/wrap-line.exp, it's a test-case I added specifically to test the behaviour of prompt wrapping in the CLI, not in TUI, so requiring allow_tui_tests there is non-sensical.
>>
> 
> Well is there a better way to detect the issue without going into this long timeout,
> or can it be fixed somehow?
> 

We could accept the string produced by horizontal-scroll-mode and 
produce an unsupported and bail out.

Thanks,
- Tom

>> The change in gdb.base/new-ui.exp LGTM.  You could submit a v2 with just that change.
>>
> 
> OK, will do.
> 
> Thanks
> Bernd.
>