From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id eA8nG+j6tWa0IAEAWB0awg (envelope-from ) for ; Fri, 09 Aug 2024 07:18:00 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Cqgy14+H; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=xx2xkcu+; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Cqgy14+H; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=xx2xkcu+; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 52D2C1E0D0; Fri, 9 Aug 2024 07:18:00 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1AC471E08C for ; Fri, 9 Aug 2024 07:17:58 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B51B63858420 for ; Fri, 9 Aug 2024 11:17:57 +0000 (GMT) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 7805F3858D34 for ; Fri, 9 Aug 2024 11:17:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7805F3858D34 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7805F3858D34 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1723202256; cv=none; b=YmmynpIKdLgHRTgpV6wBKFp+6lIKXEEzG6ccymAHk+Hjpruq5KEmOVxgpBFiKECAf8oJKVhFOZQ34VjKbhJKu21n/Ew6UnDt6U+Yg769TM/GDt1q8agxhejX5x0dEVD5mxNUbQOvGLCdK+jxSKnCbYtAzntCEfSt/S2hbI6WrX0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1723202256; c=relaxed/simple; bh=hRyDe3g/1jgpZEH2wKB0pUGEES2PQM9us1Vaonq9Jks=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=rRa8eKy7/JhF+HNXO77n+qf5UtJ0gNo+nFClGDvUI9f08x8zGqZmOsY9P5xq94Ls8SmCpHyRkso7sk6dUA5PL0oiJyjq4GLPXPGbG0cDTPgXnU5A5AEBSCG5lSt++2om5jXduD7gHv/nXHLTv4Kd6HdaEa9p84jnWPWb/ED9RHk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 77B4C1F7EA; Fri, 9 Aug 2024 11:17:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1723202253; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0IAb0e7AZwdwFxukuo0PtFOtiNpQsfmjyWTuc+Vr2AE=; b=Cqgy14+HaU4wVMqtLwrrP09i0lVuoNs4p7pNZwFjxDsGUykycPNmNll475NxgK9YzZpopm GguaUpiPlYW8OXE+V7TNhTno+41d85H1YVdjtZCJUk8jsLcptVjRNaMITyWbRRizf4rULr U2FE3ETKDgFWNpzhA5755bHv/3naUfg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1723202253; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0IAb0e7AZwdwFxukuo0PtFOtiNpQsfmjyWTuc+Vr2AE=; b=xx2xkcu+3m6ySVjrnsJ6hG3175mqQU6MmGYLwcw7Nr5Fsm7bKDBkurw6PrIb0i1/gb3mVg UVykKIIgNae08rCQ== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1723202253; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0IAb0e7AZwdwFxukuo0PtFOtiNpQsfmjyWTuc+Vr2AE=; b=Cqgy14+HaU4wVMqtLwrrP09i0lVuoNs4p7pNZwFjxDsGUykycPNmNll475NxgK9YzZpopm GguaUpiPlYW8OXE+V7TNhTno+41d85H1YVdjtZCJUk8jsLcptVjRNaMITyWbRRizf4rULr U2FE3ETKDgFWNpzhA5755bHv/3naUfg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1723202253; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0IAb0e7AZwdwFxukuo0PtFOtiNpQsfmjyWTuc+Vr2AE=; b=xx2xkcu+3m6ySVjrnsJ6hG3175mqQU6MmGYLwcw7Nr5Fsm7bKDBkurw6PrIb0i1/gb3mVg UVykKIIgNae08rCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5DD6E1379A; Fri, 9 Aug 2024 11:17:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id hodxFc36tWYeWAAAD6G6ig (envelope-from ); Fri, 09 Aug 2024 11:17:33 +0000 Message-ID: <0b383d4f-9d37-403a-9fc5-cae7e27b1673@suse.de> Date: Fri, 9 Aug 2024 13:17:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Fix test failures when TUI is not enabled To: Bernd Edlinger , "gdb-patches@sourceware.org" References: <1cdc325d-4692-425d-a2cb-52197054c015@suse.de> Content-Language: en-US From: Tom de Vries In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -4.29 X-Spamd-Result: default: False [-4.29 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; XM_UA_NO_VERSION(0.01)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_TO(0.00)[hotmail.de,sourceware.org]; TO_DN_EQ_ADDR_SOME(0.00)[]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; FREEMAIL_ENVRCPT(0.00)[hotmail.de]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FUZZY_BLOCKED(0.00)[rspamd.com]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo] X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/9/24 11:48, Bernd Edlinger wrote: > On 8/9/24 11:28, Tom de Vries wrote: >> On 8/9/24 10:47, Bernd Edlinger wrote: >>> This adds some missing require allow_tui_tests. >>> >>> When tui is not enabled those test cases do typically >>> fail, but most of them only after a long time-out: >>> >>> FAIL: gdb.base/new-ui.exp: do_test_invalid_args: new-ui with tui >>> FAIL: gdb.base/wrap-line.exp: term=ansi: width-hard-coded: wrap (timeout) >>> FAIL: gdb.base/wrap-line.exp: term=ansi: width-auto-detected: wrap (timeout) >>> FAIL: gdb.base/wrap-line.exp: term=xterm: width-hard-coded: $gdb_width == $readline_width >>> FAIL: gdb.base/wrap-line.exp: term=xterm: width-hard-coded: wrap (timeout) >>> FAIL: gdb.base/wrap-line.exp: term=xterm: width-auto-detected: $gdb_width == $readline_width >>> FAIL: gdb.base/wrap-line.exp: term=xterm: width-auto-detected: wrap (timeout) >>> FAIL: gdb.tui/wrap-line.exp: width-hard-coded: cli: wrap >>> FAIL: gdb.tui/wrap-line.exp: width-hard-coded: cli: prompt after wrap >>> FAIL: gdb.tui/wrap-line.exp: width-auto-detected: cli: wrap >>> FAIL: gdb.tui/wrap-line.exp: width-auto-detected: cli: prompt after wrap >>> --- >> >> Hi, >> >> I disabled tui support using --disable-tui, and can't reproduce the wrap-line fails you see. >> >> Is it possible that you're running into "[gdb/testsuite, stub-termcap] FAIL: gdb.base/wrap-line.exp: term=ansi: width-hard-coded: wrap (timeout)" @ https://sourceware.org/bugzilla/show_bug.cgi?id=31201 ? >> > > Yes, that could be the case. > > I did not explicitly opt-out tui, I just did never care to install > e.g. libcurses etc. and the configure did the rest. That sounds like you ran into that PR then. >> Anyway, adding require allow_tui_tests in those two test-cases looks wrong. >> > > Okay, but what is going on then? > We can get the same effect using "TERM=dumb gdb". It forces readline's horizontal-scroll-mode to activate (unfortunately, without affecting the value of the corresponding variable that we can read with bind -v). >> In the case of gdb.tui/wrap-line.exp, there is already a test that bails >> out if TUI is unsupported, but still allows testing of things that should work regardless. >> >> In the case of gdb.base/wrap-line.exp, it's a test-case I added specifically to test the behaviour of prompt wrapping in the CLI, not in TUI, so requiring allow_tui_tests there is non-sensical. >> > > Well is there a better way to detect the issue without going into this long timeout, > or can it be fixed somehow? > We could accept the string produced by horizontal-scroll-mode and produce an unsupported and bail out. Thanks, - Tom >> The change in gdb.base/new-ui.exp LGTM.  You could submit a v2 with just that change. >> > > OK, will do. > > Thanks > Bernd. >