From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id UAmGKnPhtWYTDwEAWB0awg (envelope-from ) for ; Fri, 09 Aug 2024 05:29:23 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=gYyGtxEh; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=tbWncRfk; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=gYyGtxEh; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=tbWncRfk; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 99DD21E0D0; Fri, 9 Aug 2024 05:29:23 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 63FA81E08C for ; Fri, 9 Aug 2024 05:29:21 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CEBE4385841E for ; Fri, 9 Aug 2024 09:29:20 +0000 (GMT) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id D89D7385842A for ; Fri, 9 Aug 2024 09:28:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D89D7385842A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D89D7385842A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1723195704; cv=none; b=E2519+5n76RbqF2mtYbRYhZ9I9t46+Dd89ipU0/iD3pMNMzmVlZOoTjTAv7qyf20J91Kz1meHR3tg8sTgXFetOI2qMjaVVab6RppafBXOqKKJqdvWwR1Dp9Ez9hDZiDtws9O5B4c35NNbO4vT8Y61OKAsxl3Ldl6fTOiLGKm0gQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1723195704; c=relaxed/simple; bh=r1JUVWZuNZRtWipEmcccr6XV1UGdIhEXesZ+9kIFV7Y=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=cpk9N4TAmI2Slq871EmyPN1DkAxbgIekfGUv083abqyETs4w9hVy6Bq30t9g1Io42MNoNPJy9B57sjiTVu0VUEVWXca2lcNb3M4DquEmfBc1nZnOtDwPjuOGBbHVJ5R7jrrVH5tlIgeK/gytwi1oRJGpK2iPtbs5lxiO8moYXEM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C8D3921EBE; Fri, 9 Aug 2024 09:28:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1723195701; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R0Fn+Lhx3xNys3J4rkhy+T/nDg8noDRJ30RA+Q33RUE=; b=gYyGtxEhO77nbk6pW/siUXX0ZjNKUMPIyNRkYUtKCQMzxpYOHMBpTwawTMemZ85ad3GWcz q9JG7mahNX0ud/+/w42pGAhS11ocFQtg/Q3wLerYPZlOaXWLofalPzpBn5h1KSaasd6z2z L4g/KHbr5H74rPaSJWhgMvUAz/sOln8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1723195701; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R0Fn+Lhx3xNys3J4rkhy+T/nDg8noDRJ30RA+Q33RUE=; b=tbWncRfkD59igevBQGUuBUEl5Hd3+DyRQpdt+JMTYzA7nJRZi57ZO1ssXEIysHzQ1Mk2l5 8PwtPKuBqqS+kRBg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1723195701; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R0Fn+Lhx3xNys3J4rkhy+T/nDg8noDRJ30RA+Q33RUE=; b=gYyGtxEhO77nbk6pW/siUXX0ZjNKUMPIyNRkYUtKCQMzxpYOHMBpTwawTMemZ85ad3GWcz q9JG7mahNX0ud/+/w42pGAhS11ocFQtg/Q3wLerYPZlOaXWLofalPzpBn5h1KSaasd6z2z L4g/KHbr5H74rPaSJWhgMvUAz/sOln8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1723195701; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R0Fn+Lhx3xNys3J4rkhy+T/nDg8noDRJ30RA+Q33RUE=; b=tbWncRfkD59igevBQGUuBUEl5Hd3+DyRQpdt+JMTYzA7nJRZi57ZO1ssXEIysHzQ1Mk2l5 8PwtPKuBqqS+kRBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B3CA913A7D; Fri, 9 Aug 2024 09:28:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id LMehKjXhtWbENgAAD6G6ig (envelope-from ); Fri, 09 Aug 2024 09:28:21 +0000 Message-ID: <1cdc325d-4692-425d-a2cb-52197054c015@suse.de> Date: Fri, 9 Aug 2024 11:28:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Fix test failures when TUI is not enabled To: Bernd Edlinger , "gdb-patches@sourceware.org" References: Content-Language: en-US From: Tom de Vries In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.29 X-Spamd-Result: default: False [-4.29 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; XM_UA_NO_VERSION(0.01)[]; MIME_TRACE(0.00)[0:+]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; FUZZY_BLOCKED(0.00)[rspamd.com]; FREEMAIL_TO(0.00)[hotmail.de,sourceware.org]; ARC_NA(0.00)[]; FREEMAIL_ENVRCPT(0.00)[hotmail.de]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo, sourceware.org:url] X-Spam-Level: X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/9/24 10:47, Bernd Edlinger wrote: > This adds some missing require allow_tui_tests. > > When tui is not enabled those test cases do typically > fail, but most of them only after a long time-out: > > FAIL: gdb.base/new-ui.exp: do_test_invalid_args: new-ui with tui > FAIL: gdb.base/wrap-line.exp: term=ansi: width-hard-coded: wrap (timeout) > FAIL: gdb.base/wrap-line.exp: term=ansi: width-auto-detected: wrap (timeout) > FAIL: gdb.base/wrap-line.exp: term=xterm: width-hard-coded: $gdb_width == $readline_width > FAIL: gdb.base/wrap-line.exp: term=xterm: width-hard-coded: wrap (timeout) > FAIL: gdb.base/wrap-line.exp: term=xterm: width-auto-detected: $gdb_width == $readline_width > FAIL: gdb.base/wrap-line.exp: term=xterm: width-auto-detected: wrap (timeout) > FAIL: gdb.tui/wrap-line.exp: width-hard-coded: cli: wrap > FAIL: gdb.tui/wrap-line.exp: width-hard-coded: cli: prompt after wrap > FAIL: gdb.tui/wrap-line.exp: width-auto-detected: cli: wrap > FAIL: gdb.tui/wrap-line.exp: width-auto-detected: cli: prompt after wrap > --- Hi, I disabled tui support using --disable-tui, and can't reproduce the wrap-line fails you see. Is it possible that you're running into "[gdb/testsuite, stub-termcap] FAIL: gdb.base/wrap-line.exp: term=ansi: width-hard-coded: wrap (timeout)" @ https://sourceware.org/bugzilla/show_bug.cgi?id=31201 ? Anyway, adding require allow_tui_tests in those two test-cases looks wrong. In the case of gdb.tui/wrap-line.exp, there is already a test that bails out if TUI is unsupported, but still allows testing of things that should work regardless. In the case of gdb.base/wrap-line.exp, it's a test-case I added specifically to test the behaviour of prompt wrapping in the CLI, not in TUI, so requiring allow_tui_tests there is non-sensical. The change in gdb.base/new-ui.exp LGTM. You could submit a v2 with just that change. Thanks, - Tom > gdb/testsuite/gdb.base/new-ui.exp | 8 +++++--- > gdb/testsuite/gdb.base/wrap-line.exp | 1 + > gdb/testsuite/gdb.tui/wrap-line.exp | 1 + > 3 files changed, 7 insertions(+), 3 deletions(-) > > diff --git a/gdb/testsuite/gdb.base/new-ui.exp b/gdb/testsuite/gdb.base/new-ui.exp > index 2dfcbf7e108..a56d213e527 100644 > --- a/gdb/testsuite/gdb.base/new-ui.exp > +++ b/gdb/testsuite/gdb.base/new-ui.exp > @@ -184,9 +184,11 @@ proc_with_prefix do_test_invalid_args {} { > "new-ui with bad interpreter name" > > # Test that the TUI cannot be used for a new UI. > - gdb_test "new-ui tui $extra_tty_name" \ > - "interpreter 'tui' cannot be used with a new UI" \ > - "new-ui with tui" > + if [allow_tui_tests] { > + gdb_test "new-ui tui $extra_tty_name" \ > + "interpreter 'tui' cannot be used with a new UI" \ > + "new-ui with tui" > + } > > # Test that we can continue working normally. > if ![runto_main] { > diff --git a/gdb/testsuite/gdb.base/wrap-line.exp b/gdb/testsuite/gdb.base/wrap-line.exp > index b0931a3bbb8..1a1b47410ee 100644 > --- a/gdb/testsuite/gdb.base/wrap-line.exp > +++ b/gdb/testsuite/gdb.base/wrap-line.exp > @@ -18,6 +18,7 @@ > # We set TERM on build, but we need to set it on host. That only works if > # build == host. > require {!is_remote host} > +require allow_tui_tests > > # Test both ansi (no auto-wrap) and xterm (auto-wrap). > set terms {ansi xterm} > diff --git a/gdb/testsuite/gdb.tui/wrap-line.exp b/gdb/testsuite/gdb.tui/wrap-line.exp > index 9cddcf14995..48a04ebc330 100644 > --- a/gdb/testsuite/gdb.tui/wrap-line.exp > +++ b/gdb/testsuite/gdb.tui/wrap-line.exp > @@ -17,6 +17,7 @@ > > # Required for tuiterm. > require {!is_remote host} > +require allow_tui_tests > > tuiterm_env >