From: Mike Frysinger <vapier@gentoo.org>
To: Doug Evans <dje@google.com>
Cc: toolchain-devel@blackfin.uclinux.org, gdb-patches@sourceware.org,
Joel Brobecker <brobecker@adacore.com>
Subject: Re: [toolchain-devel] [PATCH] sim: allow memory maps to default to mapped files
Date: Tue, 11 Jan 2011 16:04:00 -0000 [thread overview]
Message-ID: <AANLkTimHLOvu99ZVo505A5ht7waw_YQq6qfNbFg=XZBP@mail.gmail.com> (raw)
In-Reply-To: <AANLkTikYhU0Noq_hc7DJLDDcUThb+ESy1v=kc6Si+f6g@mail.gmail.com>
On Tue, Jan 11, 2011 at 10:07, Doug Evans wrote:
> On Sat, Jan 8, 2011 at 7:39 PM, Mike Frysinger wrote:
>> On Tuesday, December 28, 2010 07:01:20 Joel Brobecker wrote:
>>> OK. The patch looks good to me, except for the little formatting nits
>>> that I already pointed out. But can you give it a few more days for
>>> others to comment? In particular, Doug Evans is more proficient with
>>> the simulator than I am, I believe (which is not hard, considering
>>> that I have barely ever touched that code).
>>
>> i'll commit in a day or two if no one has any more feedback ...
>
> Hi. The only comment I have is that it would be nice to keep "struct
> stat s;" in its original location, but it's not necessary.
i couldnt do that without duplicating the bytes and free_length setup,
and i thought not duplicating those was more important.
-mike
next prev parent reply other threads:[~2011-01-11 16:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-27 13:10 Mike Frysinger
2010-12-28 7:38 ` Joel Brobecker
2010-12-28 7:39 ` Joel Brobecker
2010-12-28 8:02 ` Mike Frysinger
2010-12-28 7:46 ` Mike Frysinger
2010-12-28 11:00 ` Joel Brobecker
2010-12-28 14:34 ` Joel Brobecker
2010-12-28 23:17 ` Eli Zaretskii
2011-01-09 3:39 ` Mike Frysinger
2011-01-11 15:07 ` Doug Evans
2011-01-11 16:04 ` Mike Frysinger [this message]
2011-01-11 17:02 ` [toolchain-devel] " Doug Evans
2011-01-11 17:06 ` Doug Evans
2010-12-28 19:16 ` Eli Zaretskii
2010-12-29 1:52 ` Michael Snyder
2010-12-30 21:09 ` [PATCH v2] " Mike Frysinger
2011-01-11 19:05 ` [PATCH] " Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTimHLOvu99ZVo505A5ht7waw_YQq6qfNbFg=XZBP@mail.gmail.com' \
--to=vapier@gentoo.org \
--cc=brobecker@adacore.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=toolchain-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox