From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10125 invoked by alias); 11 Jan 2011 16:04:30 -0000 Received: (qmail 10093 invoked by uid 22791); 11 Jan 2011 16:04:28 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST,T_FRT_PROFILE2 X-Spam-Check-By: sourceware.org Received: from mail-iw0-f169.google.com (HELO mail-iw0-f169.google.com) (209.85.214.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 11 Jan 2011 16:04:22 +0000 Received: by iwn40 with SMTP id 40so22683179iwn.0 for ; Tue, 11 Jan 2011 08:04:21 -0800 (PST) Received: by 10.42.164.73 with SMTP id f9mr5906222icy.113.1294761860968; Tue, 11 Jan 2011 08:04:20 -0800 (PST) MIME-Version: 1.0 Received: by 10.42.165.197 with HTTP; Tue, 11 Jan 2011 08:04:00 -0800 (PST) In-Reply-To: References: <1293426471-5571-1-git-send-email-vapier@gentoo.org> <201012280238.03847.vapier@gentoo.org> <20101228120120.GE2436@adacore.com> <201101082239.10670.vapier@gentoo.org> From: Mike Frysinger Date: Tue, 11 Jan 2011 16:04:00 -0000 Message-ID: Subject: Re: [toolchain-devel] [PATCH] sim: allow memory maps to default to mapped files To: Doug Evans Cc: toolchain-devel@blackfin.uclinux.org, gdb-patches@sourceware.org, Joel Brobecker Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00220.txt.bz2 On Tue, Jan 11, 2011 at 10:07, Doug Evans wrote: > On Sat, Jan 8, 2011 at 7:39 PM, Mike Frysinger wrote: >> On Tuesday, December 28, 2010 07:01:20 Joel Brobecker wrote: >>> OK. =C2=A0The patch looks good to me, except for the little formatting = nits >>> that I already pointed out. But can you give it a few more days for >>> others to comment? =C2=A0In particular, Doug Evans is more proficient w= ith >>> the simulator than I am, I believe (which is not hard, considering >>> that I have barely ever touched that code). >> >> i'll commit in a day or two if no one has any more feedback ... > > Hi. =C2=A0The only comment I have is that it would be nice to keep "struct > stat s;" in its original location, but it's not necessary. i couldnt do that without duplicating the bytes and free_length setup, and i thought not duplicating those was more important. -mike