Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org
Subject: Re: [PATCH] sim: allow memory maps to default to mapped files
Date: Tue, 28 Dec 2010 07:38:00 -0000	[thread overview]
Message-ID: <20101228063536.GF2596@adacore.com> (raw)
In-Reply-To: <1293426471-5571-1-git-send-email-vapier@gentoo.org>

> I find it annoying when using --memory-mapfile that I also need to look
> up and manually specify the file size to the following --memory-region
> option.  So make a length of 0 in the following --memory-region trigger
> an auto-sizing of the map to the length of the file being mapped.

Generally speaking, and that's not your fault, it would be nice to
have some documentation about this module in the GDB Users' Manual.
Would you be willing to help us in that department? - nothing fancy,
but something very basic that quickly lists all available option
and what they mean.  This can be treated as a separate patch.

In terms of the user interface for this change, why not just make
the size optional? So, either the user specifies "ADDR,SIZE", or
he says "ADDR".  That way, you do not need to treat zero as special.

I see, now, that this patch has already been checked in - I must have
missed the approval email.  But the suggestions are both still interesting,
IMO.

-- 
Joel


  reply	other threads:[~2010-12-28  6:35 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-27 13:10 Mike Frysinger
2010-12-28  7:38 ` Joel Brobecker [this message]
2010-12-28  7:39   ` Joel Brobecker
2010-12-28  8:02     ` Mike Frysinger
2010-12-28  7:46   ` Mike Frysinger
2010-12-28 11:00     ` Joel Brobecker
2010-12-28 14:34     ` Joel Brobecker
2010-12-28 23:17       ` Eli Zaretskii
2011-01-09  3:39       ` Mike Frysinger
2011-01-11 15:07         ` Doug Evans
2011-01-11 16:04           ` [toolchain-devel] " Mike Frysinger
2011-01-11 17:02             ` Doug Evans
2011-01-11 17:06               ` Doug Evans
2010-12-28 19:16     ` Eli Zaretskii
2010-12-29  1:52     ` Michael Snyder
2010-12-30 21:09 ` [PATCH v2] " Mike Frysinger
2011-01-11 19:05 ` [PATCH] " Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101228063536.GF2596@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=toolchain-devel@blackfin.uclinux.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox