Re: [PATCH] sim: allow memory maps to default to mapped files

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1: Type: Text/Plain, Size: 1446 bytes --]

On Tuesday, December 28, 2010 01:35:36 Joel Brobecker wrote:
> > I find it annoying when using --memory-mapfile that I also need to look
> > up and manually specify the file size to the following --memory-region
> > option.  So make a length of 0 in the following --memory-region trigger
> > an auto-sizing of the map to the length of the file being mapped.
> 
> Generally speaking, and that's not your fault, it would be nice to
> have some documentation about this module in the GDB Users' Manual.
> Would you be willing to help us in that department? - nothing fancy,
> but something very basic that quickly lists all available option
> and what they mean.  This can be treated as a separate patch.

i dont mind writing documentation, but i dont understand texi, so ive avoided 
the format when possible.  i believe all of the gdb documentation is based in 
that format ?

> In terms of the user interface for this change, why not just make
> the size optional? So, either the user specifies "ADDR,SIZE", or
> he says "ADDR".  That way, you do not need to treat zero as special.

that's basically what my change does.  "addr,0" or just "addr" now work.  
sorry if my commit msg wasnt clear.

> I see, now, that this patch has already been checked in - I must have
> missed the approval email.  But the suggestions are both still interesting,
> IMO.

i dont recall committing this, nor do i see it in cvs ...
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]