From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21650 invoked by alias); 28 Dec 2010 07:38:34 -0000 Received: (qmail 21641 invoked by uid 22791); 28 Dec 2010 07:38:33 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 28 Dec 2010 07:38:27 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 6A5E51B4062; Tue, 28 Dec 2010 07:38:24 +0000 (UTC) From: Mike Frysinger To: Joel Brobecker Subject: Re: [PATCH] sim: allow memory maps to default to mapped files Date: Tue, 28 Dec 2010 07:46:00 -0000 User-Agent: KMail/1.13.5 (Linux/2.6.37-rc5; KDE/4.5.2; x86_64; ; ) Cc: gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org References: <1293426471-5571-1-git-send-email-vapier@gentoo.org> <20101228063536.GF2596@adacore.com> In-Reply-To: <20101228063536.GF2596@adacore.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart56255016.VrWEHaSyBA"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201012280238.03847.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00495.txt.bz2 --nextPart56255016.VrWEHaSyBA Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 1435 On Tuesday, December 28, 2010 01:35:36 Joel Brobecker wrote: > > I find it annoying when using --memory-mapfile that I also need to look > > up and manually specify the file size to the following --memory-region > > option. So make a length of 0 in the following --memory-region trigger > > an auto-sizing of the map to the length of the file being mapped. >=20 > Generally speaking, and that's not your fault, it would be nice to > have some documentation about this module in the GDB Users' Manual. > Would you be willing to help us in that department? - nothing fancy, > but something very basic that quickly lists all available option > and what they mean. This can be treated as a separate patch. i dont mind writing documentation, but i dont understand texi, so ive avoid= ed=20 the format when possible. i believe all of the gdb documentation is based = in=20 that format ? > In terms of the user interface for this change, why not just make > the size optional? So, either the user specifies "ADDR,SIZE", or > he says "ADDR". That way, you do not need to treat zero as special. that's basically what my change does. "addr,0" or just "addr" now work.=20= =20 sorry if my commit msg wasnt clear. > I see, now, that this patch has already been checked in - I must have > missed the approval email. But the suggestions are both still interestin= g, > IMO. i dont recall committing this, nor do i see it in cvs ... -mike --nextPart56255016.VrWEHaSyBA Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) iQIcBAABAgAGBQJNGZPbAAoJEEFjO5/oN/WBUaMQALlbdZc4NOzRVzTRisrFfKDA tckw9chstXN7cuCeUVsNi6Gx58jyIbwtINQUPH6rqGOJ8AKhWFTTVRLFUAEDgCDy PY+t83iMeO7Dm0Vl5kLbgw2h0vccI/Az3c7oIjHqtWv5XpzKXP9aWJwySwM7+ZBd MKC3B0ku2fmT5IftfuxrWfE/jJlBQ/XbmF62Zj1U6emcuF0lcoqc8dQr7bd92dAN mXOFrq3rBRb6w/f5QKa8xbjitcQ/g+DqqxrCeSIx1sUczrEzgyjZcXmFZGX/c4by L0DC3ESG+tAWib2xxQpDF2AMMdQudmlByiJl2/hdCggrWIPkNnp4WCgk5/c4qMPL 3YsvduRARWdwBENHIK6OZR41Y56O1j8BISDPbPsZgu2bNViAqaxmfwlE2c9QEyl7 rlJXSOW/ozjWZr/3YLCrdVdsKMjIe5MTdIbxKyM1o7cjoGWEngPpBeJ9oPLqrAaJ PZI0ownxikznCDbBjLeSsTxE/+JoC9+t+01o3RIMoZXv/wPng7CqZRFBQ4Oi4U5I SuRlLllZZIxdGpuh02VRRbKmkgVhPyVL7yU85bhTSBF+MsFhXw8038KAIXGGWBB3 YBhkB293ROdExEb09UoPOb5Agf8qzAHdMdWutXrpDG83aKipjBwsTvNCEHyfy7hF Mgy0gwBFJrqH38uGcBH/ =Be2b -----END PGP SIGNATURE----- --nextPart56255016.VrWEHaSyBA--