From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14268 invoked by alias); 28 Dec 2010 06:35:54 -0000 Received: (qmail 14260 invoked by uid 22791); 28 Dec 2010 06:35:53 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 28 Dec 2010 06:35:48 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 848422BAB1C; Tue, 28 Dec 2010 01:35:46 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id DzgnrgOVsFne; Tue, 28 Dec 2010 01:35:46 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 13A262BAAFC; Tue, 28 Dec 2010 01:35:46 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id C4B6E1457BB; Tue, 28 Dec 2010 07:35:36 +0100 (CET) Date: Tue, 28 Dec 2010 07:38:00 -0000 From: Joel Brobecker To: Mike Frysinger Cc: gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org Subject: Re: [PATCH] sim: allow memory maps to default to mapped files Message-ID: <20101228063536.GF2596@adacore.com> References: <1293426471-5571-1-git-send-email-vapier@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1293426471-5571-1-git-send-email-vapier@gentoo.org> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-12/txt/msg00493.txt.bz2 > I find it annoying when using --memory-mapfile that I also need to look > up and manually specify the file size to the following --memory-region > option. So make a length of 0 in the following --memory-region trigger > an auto-sizing of the map to the length of the file being mapped. Generally speaking, and that's not your fault, it would be nice to have some documentation about this module in the GDB Users' Manual. Would you be willing to help us in that department? - nothing fancy, but something very basic that quickly lists all available option and what they mean. This can be treated as a separate patch. In terms of the user interface for this change, why not just make the size optional? So, either the user specifies "ADDR,SIZE", or he says "ADDR". That way, you do not need to treat zero as special. I see, now, that this patch has already been checked in - I must have missed the approval email. But the suggestions are both still interesting, IMO. -- Joel