Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Doug Evans <dje@google.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Joel Brobecker <brobecker@adacore.com>,
	       Michael Snyder <msnyder@vmware.com>,
	Eli Zaretskii <eliz@gnu.org>,
	       "mark.kettenis@xs4all.nl" <mark.kettenis@xs4all.nl>,
	       "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch] more comment cleanups
Date: Mon, 03 Jan 2011 19:33:00 -0000	[thread overview]
Message-ID: <AANLkTikweT-wBNcbO_-CwFGuKhRRn3gv1SMig3GRsDWa@mail.gmail.com> (raw)
In-Reply-To: <AANLkTim-AA1+9YmBfQ-YMe2WdCrpTqx3BzJcaYRJL_-s@mail.gmail.com>

On Sun, Jan 2, 2011 at 9:05 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Sun, Jan 2, 2011 at 8:33 PM, Joel Brobecker <brobecker@adacore.com> wrote:
>>> So what do others think about source lines over 70 columns?
>>
>> Enforcing a maximum length of 70 characters seems awfully low to me.
>> It's fine if someone decides to use 70 characters for his comments,
>> of even his code, but I think that 76 or 78 would give better results.
>> I even allow myself to go up to 80 when splitting a line makes it
>> particularly ugly and hard to read...
>>
>
> ChangeLog should be limited to 74 columns:
>
> [hjl@gnu-6 gdb]$ tail gdb/ChangeLog
>
> For older changes see ChangeLog-2009.
>
>
> Local Variables:
> mode: change-log
> left-margin: 8
> fill-column: 74
> version-control: never
> coding: utf-8
> End:
> [hjl@gnu-6 gdb]$

OOC, where did the number 74 for ChangeLog entries come from?

Having different values for different kinds of files seems problematic
and a nuisance.

If I had a choice, it'd be a convention of 79 for changelogs,
comments, code, .texi files, etc.
[Maybe I'd have a special case to have for some kind of file.  The
only special case that comes to mind is in .texi files where for
certain things the line length spills over into the printed page, and
one needs to manually have shorter lines in the .texi source.]

My $0.02.


  parent reply	other threads:[~2011-01-03 19:33 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-31 23:26 Michael Snyder
     [not found] ` <201012312312.oBVNC4fc013647@glazunov.sibelius.xs4all.nl>
     [not found]   ` <AANLkTimc4kNHOfO2B95cyKjN9SN1O_+LQ3O_4FpwZ3rR@mail.gmail.com>
2011-01-01  0:20     ` Michael Snyder
2011-01-01  9:11       ` Eli Zaretskii
2011-01-01 18:26         ` Michael Snyder
2011-01-03  4:43           ` Joel Brobecker
2011-01-03  5:06             ` H.J. Lu
2011-01-03  7:35               ` Joel Brobecker
2011-01-03  7:56                 ` Eli Zaretskii
2011-01-03  8:06                   ` Joel Brobecker
2011-01-03 17:45                     ` Eli Zaretskii
2011-01-03 19:33               ` Doug Evans [this message]
2011-01-03 19:43                 ` Eli Zaretskii
2011-01-03  8:05             ` Mark Kettenis
2011-01-03 20:35               ` Michael Snyder
2011-01-03 20:43                 ` Eli Zaretskii
2011-01-03 13:00             ` Eli Zaretskii
2011-01-03 16:00               ` Joel Brobecker
2011-01-03 20:37                 ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTikweT-wBNcbO_-CwFGuKhRRn3gv1SMig3GRsDWa@mail.gmail.com \
    --to=dje@google.com \
    --cc=brobecker@adacore.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=hjl.tools@gmail.com \
    --cc=mark.kettenis@xs4all.nl \
    --cc=msnyder@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox