From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20365 invoked by alias); 3 Jan 2011 19:33:12 -0000 Received: (qmail 20357 invoked by uid 22791); 3 Jan 2011 19:33:11 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 03 Jan 2011 19:33:07 +0000 Received: from wpaz5.hot.corp.google.com (wpaz5.hot.corp.google.com [172.24.198.69]) by smtp-out.google.com with ESMTP id p03JX5Pr000355 for ; Mon, 3 Jan 2011 11:33:05 -0800 Received: from qwg5 (qwg5.prod.google.com [10.241.194.133]) by wpaz5.hot.corp.google.com with ESMTP id p03JVPD5008597 for ; Mon, 3 Jan 2011 11:33:04 -0800 Received: by qwg5 with SMTP id 5so12974873qwg.34 for ; Mon, 03 Jan 2011 11:33:04 -0800 (PST) MIME-Version: 1.0 Received: by 10.229.95.200 with SMTP id e8mr18091136qcn.213.1294083184421; Mon, 03 Jan 2011 11:33:04 -0800 (PST) Received: by 10.220.118.80 with HTTP; Mon, 3 Jan 2011 11:33:04 -0800 (PST) In-Reply-To: References: <4D1E60A0.1020601@vmware.com> <201012312312.oBVNC4fc013647@glazunov.sibelius.xs4all.nl> <4D1E732E.4090002@vmware.com> <834o9tq96f.fsf@gnu.org> <4D1F71B0.9060006@vmware.com> <20110103043359.GO2396@adacore.com> Date: Mon, 03 Jan 2011 19:33:00 -0000 Message-ID: Subject: Re: [patch] more comment cleanups From: Doug Evans To: "H.J. Lu" Cc: Joel Brobecker , Michael Snyder , Eli Zaretskii , "mark.kettenis@xs4all.nl" , "gdb-patches@sourceware.org" Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00047.txt.bz2 On Sun, Jan 2, 2011 at 9:05 PM, H.J. Lu wrote: > On Sun, Jan 2, 2011 at 8:33 PM, Joel Brobecker wrote: >>> So what do others think about source lines over 70 columns? >> >> Enforcing a maximum length of 70 characters seems awfully low to me. >> It's fine if someone decides to use 70 characters for his comments, >> of even his code, but I think that 76 or 78 would give better results. >> I even allow myself to go up to 80 when splitting a line makes it >> particularly ugly and hard to read... >> > > ChangeLog should be limited to 74 columns: > > [hjl@gnu-6 gdb]$ tail gdb/ChangeLog > > For older changes see ChangeLog-2009. > > > Local Variables: > mode: change-log > left-margin: 8 > fill-column: 74 > version-control: never > coding: utf-8 > End: > [hjl@gnu-6 gdb]$ OOC, where did the number 74 for ChangeLog entries come from? Having different values for different kinds of files seems problematic and a nuisance. If I had a choice, it'd be a convention of 79 for changelogs, comments, code, .texi files, etc. [Maybe I'd have a special case to have for some kind of file. The only special case that comes to mind is in .texi files where for certain things the line length spills over into the printed page, and one needs to manually have shorter lines in the .texi source.] My $0.02.