From: Michael Snyder <msnyder@vmware.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Mark Kettenis <mark.kettenis@xs4all.nl>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch] more comment cleanups
Date: Sat, 01 Jan 2011 00:20:00 -0000 [thread overview]
Message-ID: <4D1E732E.4090002@vmware.com> (raw)
In-Reply-To: <AANLkTimc4kNHOfO2B95cyKjN9SN1O_+LQ3O_4FpwZ3rR@mail.gmail.com>
H.J. Lu wrote:
> On Fri, Dec 31, 2010 at 3:12 PM, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
>>> Date: Fri, 31 Dec 2010 15:00:48 -0800
>>> From: Michael Snyder <msnyder@vmware.com>
>>>
>>> Also break up some long lines.
>> Sorry Michael, but I don't think breaking up lines like that actually
>> improves the readability of the code. Many of those fit comfrotably
>> in standard 80-column display. By breaking them up they take up more
>> vertical space, which means that I can see less code.
>>
>
> FWIW, I prefer 72 column to show line numbers in 80 column terminal.
When we get new contributions, we don't allow them to go out to 80
columns. I'm just trying to apply the same standard to the old code.
But maybe I did go a bit overboard on some of this. I'll try to be more
restrained.
I'm being guided by where eMacs breaks up lines when I format a comment,
which is something like 72 columns.
next prev parent reply other threads:[~2011-01-01 0:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-31 23:26 Michael Snyder
[not found] ` <201012312312.oBVNC4fc013647@glazunov.sibelius.xs4all.nl>
[not found] ` <AANLkTimc4kNHOfO2B95cyKjN9SN1O_+LQ3O_4FpwZ3rR@mail.gmail.com>
2011-01-01 0:20 ` Michael Snyder [this message]
2011-01-01 9:11 ` Eli Zaretskii
2011-01-01 18:26 ` Michael Snyder
2011-01-03 4:43 ` Joel Brobecker
2011-01-03 5:06 ` H.J. Lu
2011-01-03 7:35 ` Joel Brobecker
2011-01-03 7:56 ` Eli Zaretskii
2011-01-03 8:06 ` Joel Brobecker
2011-01-03 17:45 ` Eli Zaretskii
2011-01-03 19:33 ` Doug Evans
2011-01-03 19:43 ` Eli Zaretskii
2011-01-03 8:05 ` Mark Kettenis
2011-01-03 20:35 ` Michael Snyder
2011-01-03 20:43 ` Eli Zaretskii
2011-01-03 13:00 ` Eli Zaretskii
2011-01-03 16:00 ` Joel Brobecker
2011-01-03 20:37 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D1E732E.4090002@vmware.com \
--to=msnyder@vmware.com \
--cc=gdb-patches@sourceware.org \
--cc=hjl.tools@gmail.com \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox