Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@vmware.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: "brobecker@adacore.com" <brobecker@adacore.com>,
	 "eliz@gnu.org" <eliz@gnu.org>,
	"hjl.tools@gmail.com" <hjl.tools@gmail.com>,
	 "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patch] more comment cleanups
Date: Mon, 03 Jan 2011 20:35:00 -0000	[thread overview]
Message-ID: <4D2232ED.3080406@vmware.com> (raw)
In-Reply-To: <201101030804.p0384T2N020327@glazunov.sibelius.xs4all.nl>

Mark Kettenis wrote:
>> Date: Mon, 3 Jan 2011 08:33:59 +0400
>> From: Joel Brobecker <brobecker@adacore.com>
>>
>>> So what do others think about source lines over 70 columns?
>> Enforcing a maximum length of 70 characters seems awfully low to me.
>> It's fine if someone decides to use 70 characters for his comments,
>> of even his code, but I think that 76 or 78 would give better results.
>> I even allow myself to go up to 80 when splitting a line makes it
>> particularly ugly and hard to read...
> 
> 70 characters really isn't that low for comments that start in the
> first column; look at a properly typeset book and count the number of
> characters per line.  However, I fully agree with you that it
> shouldn't be strictly enforced.  If for example, it means that you end
> up wrapping a single line comment such that you end up with a single
> word on the next line I strongly prefer not to wrap and keep the
> comment on one line such that it takes up less vertical space.
> 
> The same holds for code.  If I can keep things on a single line, I'll
> attempt to do so, even if it means I'll get a little bit closer to the
> 80 character "hard" limit.  It's one of the reasons I never believed
> in running tools like indent to automatically format source code.

OK, so at least we agree that there should be a "hard" limit at 80?
Really 79, otherwise emacs will wrap it?

I'd like to know that there is a "hard" limit, and I would like to
do some fixups of lines that are now too long.



  reply	other threads:[~2011-01-03 20:35 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-31 23:26 Michael Snyder
     [not found] ` <201012312312.oBVNC4fc013647@glazunov.sibelius.xs4all.nl>
     [not found]   ` <AANLkTimc4kNHOfO2B95cyKjN9SN1O_+LQ3O_4FpwZ3rR@mail.gmail.com>
2011-01-01  0:20     ` Michael Snyder
2011-01-01  9:11       ` Eli Zaretskii
2011-01-01 18:26         ` Michael Snyder
2011-01-03  4:43           ` Joel Brobecker
2011-01-03  5:06             ` H.J. Lu
2011-01-03  7:35               ` Joel Brobecker
2011-01-03  7:56                 ` Eli Zaretskii
2011-01-03  8:06                   ` Joel Brobecker
2011-01-03 17:45                     ` Eli Zaretskii
2011-01-03 19:33               ` Doug Evans
2011-01-03 19:43                 ` Eli Zaretskii
2011-01-03  8:05             ` Mark Kettenis
2011-01-03 20:35               ` Michael Snyder [this message]
2011-01-03 20:43                 ` Eli Zaretskii
2011-01-03 13:00             ` Eli Zaretskii
2011-01-03 16:00               ` Joel Brobecker
2011-01-03 20:37                 ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D2232ED.3080406@vmware.com \
    --to=msnyder@vmware.com \
    --cc=brobecker@adacore.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=hjl.tools@gmail.com \
    --cc=mark.kettenis@xs4all.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox