From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11676 invoked by alias); 1 Jan 2011 00:20:05 -0000 Received: (qmail 11666 invoked by uid 22791); 1 Jan 2011 00:20:04 -0000 X-SWARE-Spam-Status: No, hits=-4.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 01 Jan 2011 00:20:00 +0000 Received: from mailhost4.vmware.com (mailhost4.vmware.com [10.16.67.124]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 0EE9211003; Fri, 31 Dec 2010 16:19:59 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost4.vmware.com (Postfix) with ESMTP id 061F0C9A4F; Fri, 31 Dec 2010 16:19:59 -0800 (PST) Message-ID: <4D1E732E.4090002@vmware.com> Date: Sat, 01 Jan 2011 00:20:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: "H.J. Lu" CC: Mark Kettenis , "gdb-patches@sourceware.org" Subject: Re: [patch] more comment cleanups References: <4D1E60A0.1020601@vmware.com> <201012312312.oBVNC4fc013647@glazunov.sibelius.xs4all.nl> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00000.txt.bz2 H.J. Lu wrote: > On Fri, Dec 31, 2010 at 3:12 PM, Mark Kettenis wrote: >>> Date: Fri, 31 Dec 2010 15:00:48 -0800 >>> From: Michael Snyder >>> >>> Also break up some long lines. >> Sorry Michael, but I don't think breaking up lines like that actually >> improves the readability of the code. Many of those fit comfrotably >> in standard 80-column display. By breaking them up they take up more >> vertical space, which means that I can see less code. >> > > FWIW, I prefer 72 column to show line numbers in 80 column terminal. When we get new contributions, we don't allow them to go out to 80 columns. I'm just trying to apply the same standard to the old code. But maybe I did go a bit overboard on some of this. I'll try to be more restrained. I'm being guided by where eMacs breaks up lines when I format a comment, which is something like 72 columns.