From: Doug Evans <dje@google.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org, Paul Pluzhnikov <ppluzhnikov@google.com>
Subject: Re: [patch] Add "debug jit" for easier tracing of JIT support internals
Date: Wed, 05 Jan 2011 23:26:00 -0000 [thread overview]
Message-ID: <AANLkTi=FxZOafO_Gf=5iaS+vT+-bCf8ngMF8G-OPuDUx@mail.gmail.com> (raw)
In-Reply-To: <201101052257.30806.pedro@codesourcery.com>
On Wed, Jan 5, 2011 at 2:57 PM, Pedro Alves <pedro@codesourcery.com> wrote:
> On Wednesday 05 January 2011 20:01:50, Doug Evans wrote:
>> Paul Pluzhnikov <ppluzhnikov@google.com> wrote:
>> > +
>> > +static void
>> > +show_jit_debug (struct ui_file *file, int from_tty,
>> > + struct cmd_list_element *c, const char *value)
>> > +{
>> > + fprintf_filtered (file, _("JIT debugging is %s.\n"), value);
>> > +}
>> > +
>
> ...
>
>> and while I haven't tried it, I wonder if show_jit_debug is necessary
>> (bummer if it is, we should fix that).
>
> It's necessary for i18n. The default callback (deprecated_show_value_hack)
> does:
>
> /* Print doc minus "show" at start. */
> print_doc_line (gdb_stdout, c->doc + 5);
Ah, forgot.
> which obviously only works in English.
>
> Until and if we find a better way, an implemented show callback
> should be a requirement for all new commands.
It feels like if *some* better way is that hard, we're not very clever. :-)
next prev parent reply other threads:[~2011-01-05 23:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-05 19:36 Paul Pluzhnikov
2011-01-05 20:02 ` Doug Evans
2011-01-05 22:57 ` Pedro Alves
2011-01-05 23:16 ` Paul Pluzhnikov
2011-01-05 23:28 ` Pedro Alves
2011-01-05 23:49 ` Paul Pluzhnikov
2011-01-06 0:45 ` Pedro Alves
2011-01-06 1:09 ` Paul Pluzhnikov
2011-01-06 4:14 ` Eli Zaretskii
2011-01-05 23:26 ` Doug Evans [this message]
2011-01-05 23:34 ` Pedro Alves
2011-01-06 19:45 ` Tom Tromey
2011-01-06 19:52 ` Paul Pluzhnikov
2011-01-05 20:57 ` Eli Zaretskii
2011-01-05 21:53 ` Paul Pluzhnikov
2011-01-05 22:51 ` Pedro Alves
2011-01-06 4:00 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=FxZOafO_Gf=5iaS+vT+-bCf8ngMF8G-OPuDUx@mail.gmail.com' \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
--cc=ppluzhnikov@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox