From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1871 invoked by alias); 5 Jan 2011 23:26:33 -0000 Received: (qmail 1844 invoked by uid 22791); 5 Jan 2011 23:26:32 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 05 Jan 2011 23:26:27 +0000 Received: from hpaq12.eem.corp.google.com (hpaq12.eem.corp.google.com [172.25.149.12]) by smtp-out.google.com with ESMTP id p05NQOap016967 for ; Wed, 5 Jan 2011 15:26:24 -0800 Received: from yxd39 (yxd39.prod.google.com [10.190.1.231]) by hpaq12.eem.corp.google.com with ESMTP id p05NQMRB026800 for ; Wed, 5 Jan 2011 15:26:23 -0800 Received: by yxd39 with SMTP id 39so8166846yxd.26 for ; Wed, 05 Jan 2011 15:26:22 -0800 (PST) MIME-Version: 1.0 Received: by 10.90.62.19 with SMTP id k19mr1314787aga.180.1294269982442; Wed, 05 Jan 2011 15:26:22 -0800 (PST) Received: by 10.90.20.3 with HTTP; Wed, 5 Jan 2011 15:26:22 -0800 (PST) In-Reply-To: <201101052257.30806.pedro@codesourcery.com> References: <20110105193621.A8CBF190B3A@elbrus2.mtv.corp.google.com> <201101052257.30806.pedro@codesourcery.com> Date: Wed, 05 Jan 2011 23:26:00 -0000 Message-ID: Subject: Re: [patch] Add "debug jit" for easier tracing of JIT support internals From: Doug Evans To: Pedro Alves Cc: gdb-patches@sourceware.org, Paul Pluzhnikov Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00099.txt.bz2 On Wed, Jan 5, 2011 at 2:57 PM, Pedro Alves wrote: > On Wednesday 05 January 2011 20:01:50, Doug Evans wrote: >> Paul Pluzhnikov wrote: >> > + >> > +static void >> > +show_jit_debug (struct ui_file *file, int from_tty, >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 struct cmd_list_element *c, const char *= value) >> > +{ >> > + =A0fprintf_filtered (file, _("JIT debugging is %s.\n"), value); >> > +} >> > + > > ... > >> and while I haven't tried it, I wonder if show_jit_debug is necessary >> (bummer if it is, we should fix that). > > It's necessary for i18n. =A0The default callback (deprecated_show_value_h= ack) > does: > > =A0/* Print doc minus "show" at start. =A0*/ > =A0print_doc_line (gdb_stdout, c->doc + 5); Ah, forgot. > which obviously only works in English. > > Until and if we find a better way, an implemented show callback > should be a requirement for all new commands. It feels like if *some* better way is that hard, we're not very clever. :-)