Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Doug Evans <dje@google.com>, Paul Pluzhnikov <ppluzhnikov@google.com>
Subject: Re: [patch] Add "debug jit" for easier tracing of JIT support internals
Date: Wed, 05 Jan 2011 23:34:00 -0000	[thread overview]
Message-ID: <201101052334.13475.pedro@codesourcery.com> (raw)
In-Reply-To: <AANLkTi=FxZOafO_Gf=5iaS+vT+-bCf8ngMF8G-OPuDUx@mail.gmail.com>

On Wednesday 05 January 2011 23:26:22, Doug Evans wrote:
> > Until and if we find a better way, an implemented show callback
> > should be a requirement for all new commands.
> 
> It feels like if some better way is that hard, we're not very clever. :-)

An alternative I can think of, would be to come up with a GDB specific
printf formatter for "replace by the value of the setting", and then
instead of a code callback, we'd install a show string.  That is, 
data driven instead of code driven, so instead, we'd register
the command like:

  add_setshow_zinteger_cmd ("jit", class_maintenance, &jit_debug, _("\
Set JIT debugging."), _("\
Show JIT debugging."), _("\
When non-zero, JIT debugging is enabled."),
                           NULL,
                           _("\
JIT debugging is: %V"),
                           &setdebuglist, &showdebuglist);

With %V being the new format string in question.

We'd still need to write the "show" string, but it's more
centralized and readable than putting it in a separate callback
function.

-- 
Pedro Alves


  reply	other threads:[~2011-01-05 23:34 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-05 19:36 Paul Pluzhnikov
2011-01-05 20:02 ` Doug Evans
2011-01-05 22:57   ` Pedro Alves
2011-01-05 23:16     ` Paul Pluzhnikov
2011-01-05 23:28       ` Pedro Alves
2011-01-05 23:49         ` Paul Pluzhnikov
2011-01-06  0:45           ` Pedro Alves
2011-01-06  1:09             ` Paul Pluzhnikov
2011-01-06  4:14               ` Eli Zaretskii
2011-01-05 23:26     ` Doug Evans
2011-01-05 23:34       ` Pedro Alves [this message]
2011-01-06 19:45         ` Tom Tromey
2011-01-06 19:52           ` Paul Pluzhnikov
2011-01-05 20:57 ` Eli Zaretskii
2011-01-05 21:53   ` Paul Pluzhnikov
2011-01-05 22:51     ` Pedro Alves
2011-01-06  4:00     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201101052334.13475.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=ppluzhnikov@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox