* [RFA] Fix i386-sse.exp regression on Darwin
@ 2009-02-05 16:03 Tristan Gingold
2009-02-05 17:32 ` Mark Kettenis
0 siblings, 1 reply; 3+ messages in thread
From: Tristan Gingold @ 2009-02-05 16:03 UTC (permalink / raw)
To: gdb-patches
Hi,
xmm0 is a scratch register for the Darwin/i386 ABI and therefore may
be destroyed by calling a function.
This patch fix a regression on Darwin by replacing a function call by
a asm nop. The only purpose of the
function call was to be able to put a breakpoint.
Tristan.
testsuite:
2009-02-05 Tristan Gingold <gingold@adacore.com>
* gdb.arch/i386-sse.c (main): Replace call to puts by an nop asm.
diff -u -r1.5 i386-sse.c
--- testsuite/gdb.arch/i386-sse.c 3 Jan 2009 05:58:03 -0000 1.5
+++ testsuite/gdb.arch/i386-sse.c 5 Feb 2009 16:02:36 -0000
@@ -66,7 +66,7 @@
: "r" (data)
: "xmm0", "xmm1", "xmm2", "xmm3", "xmm4", "xmm5", "xmm6",
"xmm7");
- puts ("Hi!"); /* first breakpoint here */
+ asm ("nop"); /* first breakpoint here */
asm (
"movaps %%xmm0, 0(%0)\n\t"
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [RFA] Fix i386-sse.exp regression on Darwin
2009-02-05 16:03 [RFA] Fix i386-sse.exp regression on Darwin Tristan Gingold
@ 2009-02-05 17:32 ` Mark Kettenis
2009-02-06 8:49 ` Tristan Gingold
0 siblings, 1 reply; 3+ messages in thread
From: Mark Kettenis @ 2009-02-05 17:32 UTC (permalink / raw)
To: gingold; +Cc: gdb-patches
> From: Tristan Gingold <gingold@adacore.com>
> Date: Thu, 5 Feb 2009 17:02:49 +0100
>
> Hi,
>
> xmm0 is a scratch register for the Darwin/i386 ABI and therefore may
> be destroyed by calling a function.
> This patch fix a regression on Darwin by replacing a function call by
> a asm nop. The only purpose of the
> function call was to be able to put a breakpoint.
ok with me
> testsuite:
> 2009-02-05 Tristan Gingold <gingold@adacore.com>
>
> * gdb.arch/i386-sse.c (main): Replace call to puts by an nop asm.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] Fix i386-sse.exp regression on Darwin
2009-02-05 17:32 ` Mark Kettenis
@ 2009-02-06 8:49 ` Tristan Gingold
0 siblings, 0 replies; 3+ messages in thread
From: Tristan Gingold @ 2009-02-06 8:49 UTC (permalink / raw)
To: Mark Kettenis; +Cc: gdb-patches
On Feb 5, 2009, at 6:31 PM, Mark Kettenis wrote:
>> From: Tristan Gingold <gingold@adacore.com>
>> Date: Thu, 5 Feb 2009 17:02:49 +0100
>>
>> Hi,
>>
>> xmm0 is a scratch register for the Darwin/i386 ABI and therefore may
>> be destroyed by calling a function.
>> This patch fix a regression on Darwin by replacing a function call by
>> a asm nop. The only purpose of the
>> function call was to be able to put a breakpoint.
>
> ok with me
Thanks, committed.
Tristan.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-02-06 8:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-02-05 16:03 [RFA] Fix i386-sse.exp regression on Darwin Tristan Gingold
2009-02-05 17:32 ` Mark Kettenis
2009-02-06 8:49 ` Tristan Gingold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox