From: Tristan Gingold <gingold@adacore.com>
To: gdb-patches@sourceware.org
Subject: [RFA] Fix i386-sse.exp regression on Darwin
Date: Thu, 05 Feb 2009 16:03:00 -0000 [thread overview]
Message-ID: <A957CEE8-7213-428A-9696-3B54B51AC8A7@adacore.com> (raw)
Hi,
xmm0 is a scratch register for the Darwin/i386 ABI and therefore may
be destroyed by calling a function.
This patch fix a regression on Darwin by replacing a function call by
a asm nop. The only purpose of the
function call was to be able to put a breakpoint.
Tristan.
testsuite:
2009-02-05 Tristan Gingold <gingold@adacore.com>
* gdb.arch/i386-sse.c (main): Replace call to puts by an nop asm.
diff -u -r1.5 i386-sse.c
--- testsuite/gdb.arch/i386-sse.c 3 Jan 2009 05:58:03 -0000 1.5
+++ testsuite/gdb.arch/i386-sse.c 5 Feb 2009 16:02:36 -0000
@@ -66,7 +66,7 @@
: "r" (data)
: "xmm0", "xmm1", "xmm2", "xmm3", "xmm4", "xmm5", "xmm6",
"xmm7");
- puts ("Hi!"); /* first breakpoint here */
+ asm ("nop"); /* first breakpoint here */
asm (
"movaps %%xmm0, 0(%0)\n\t"
next reply other threads:[~2009-02-05 16:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-05 16:03 Tristan Gingold [this message]
2009-02-05 17:32 ` Mark Kettenis
2009-02-06 8:49 ` Tristan Gingold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A957CEE8-7213-428A-9696-3B54B51AC8A7@adacore.com \
--to=gingold@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox