Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Metzger, Markus T" <markus.t.metzger@intel.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Joel Brobecker <brobecker@adacore.com>,
	"gdb-patches@sourceware.org"	<gdb-patches@sourceware.org>,
	"Pedro Alves (palves@redhat.com)"	<palves@redhat.com>
Subject: RE: [patch] Fix cleanup in finish_command
Date: Tue, 02 Jul 2013 14:50:00 -0000	[thread overview]
Message-ID: <A78C989F6D9628469189715575E55B230A975B8E@IRSMSX104.ger.corp.intel.com> (raw)
In-Reply-To: <A78C989F6D9628469189715575E55B230A96FFB6@IRSMSX104.ger.corp.intel.com>

> -----Original Message-----
> From: Metzger, Markus T
> Sent: Friday, June 21, 2013 10:23 AM


> > > Am I allowed to throw_error() in target functions?
> > > Or should I just warn and return normally?
> > > Or just return and not even warn?
> >
> > There isn't a technical reason why target functions could not throw.
> > One should just debug why the breakpoint is freed twice, I haven't done so
> > yet.
> 
> I can do this, but I won't be able to start right away.

Looks like throwing an error in the to_fetch_registers function is both
unexpected and unnecessary.  There is already a register_status enum
value to indicate that a register is not available.

When I simply return, I get exactly what I want, i.e. "info reg" prints all
registers except for rip as *value not available*.

I'll replace the throws with a simple return.  Also in to_store_registers
and to_xfer_partial.

Regards,
Markus.

Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052


  reply	other threads:[~2013-07-02 14:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-19 21:42 Jan Kratochvil
2013-06-20 14:42 ` Jan Kratochvil
2013-06-20 15:26   ` Joel Brobecker
2013-06-20 15:37     ` Metzger, Markus T
2013-06-20 16:45       ` Jan Kratochvil
2013-06-21  8:14         ` Metzger, Markus T
2013-06-21  8:23           ` Jan Kratochvil
2013-06-21  8:25             ` Metzger, Markus T
2013-07-02 14:50               ` Metzger, Markus T [this message]
2013-06-21 12:56           ` Jan Kratochvil
2013-06-20 16:06     ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A78C989F6D9628469189715575E55B230A975B8E@IRSMSX104.ger.corp.intel.com \
    --to=markus.t.metzger@intel.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox