From: Joel Brobecker <brobecker@adacore.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org, Markus Metzger <markus.t.metzger@intel.com>
Subject: Re: [patch] Fix cleanup in finish_command
Date: Thu, 20 Jun 2013 15:26:00 -0000 [thread overview]
Message-ID: <20130620151806.GD4724@adacore.com> (raw)
In-Reply-To: <20130620143118.GA11929@host2.jankratochvil.net>
> BTW I have found the crash happens even with this patch, I haven't found the
> real cause yet.
Interesting, as I couldn't understand the relationship between
the backtrace and the patch... You might also be in a situation
similar to what I faced on Darwin: a correct cleanup fix triggering
a latent bug; In that situation I found it useful to first git-bisect
to narrow down the commit that caused the change of behavior, and
then finish the bug off with valgrind's help.
--
Joel
next prev parent reply other threads:[~2013-06-20 15:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-19 21:42 Jan Kratochvil
2013-06-20 14:42 ` Jan Kratochvil
2013-06-20 15:26 ` Joel Brobecker [this message]
2013-06-20 15:37 ` Metzger, Markus T
2013-06-20 16:45 ` Jan Kratochvil
2013-06-21 8:14 ` Metzger, Markus T
2013-06-21 8:23 ` Jan Kratochvil
2013-06-21 8:25 ` Metzger, Markus T
2013-07-02 14:50 ` Metzger, Markus T
2013-06-21 12:56 ` Jan Kratochvil
2013-06-20 16:06 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130620151806.GD4724@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=markus.t.metzger@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox