From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5560 invoked by alias); 20 Jun 2013 15:18:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5550 invoked by uid 89); 20 Jun 2013 15:18:11 -0000 X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO autolearn=ham version=3.3.1 Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 20 Jun 2013 15:18:10 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 2CBEB1C66D4; Thu, 20 Jun 2013 11:18:09 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id DWUj7UgZxVJL; Thu, 20 Jun 2013 11:18:09 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C9C161C6539; Thu, 20 Jun 2013 11:18:08 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 44ED8C2B5F; Thu, 20 Jun 2013 08:18:06 -0700 (PDT) Date: Thu, 20 Jun 2013 15:26:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: gdb-patches@sourceware.org, Markus Metzger Subject: Re: [patch] Fix cleanup in finish_command Message-ID: <20130620151806.GD4724@adacore.com> References: <20130619211444.GA29379@host2.jankratochvil.net> <20130620143118.GA11929@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130620143118.GA11929@host2.jankratochvil.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2013-06/txt/msg00541.txt.bz2 > BTW I have found the crash happens even with this patch, I haven't found the > real cause yet. Interesting, as I couldn't understand the relationship between the backtrace and the patch... You might also be in a situation similar to what I faced on Darwin: a correct cleanup fix triggering a latent bug; In that situation I found it useful to first git-bisect to narrow down the commit that caused the change of behavior, and then finish the bug off with valgrind's help. -- Joel